Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding mobile collapsible nav for multipage links #744

Merged
merged 6 commits into from
Sep 11, 2017

Conversation

gvn
Copy link
Contributor

@gvn gvn commented Sep 8, 2017

Related to #712

mmmavis
mmmavis previously approved these changes Sep 11, 2017
Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good just needs a tiny CSS improvement.

align-items: center;
}

.expander {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure the cursor is set to pointer on hover.

Copy link
Collaborator

@mmmavis mmmavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gvn gvn merged commit 4048bf0 into MozillaFoundation:master Sep 11, 2017
@gvn gvn deleted the gh-712 branch September 11, 2017 23:13
gvn added a commit that referenced this pull request Sep 18, 2017
* multinav basics

* nav open/close

* adding chevron expander

* compressing svg

* margin tweak

* cursor for all buttons
gvn added a commit that referenced this pull request Sep 18, 2017
* multinav basics

* nav open/close

* adding chevron expander

* compressing svg

* margin tweak

* cursor for all buttons
gvn added a commit that referenced this pull request Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants