-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TP1-38][Main Nav] Nav Settings #12137
Merged
jhonatan-lopes
merged 6 commits into
feature-branch/main-nav-dropdown
from
feature/TP1-38/nav-settings
Apr 4, 2024
Merged
[TP1-38][Main Nav] Nav Settings #12137
jhonatan-lopes
merged 6 commits into
feature-branch/main-nav-dropdown
from
feature/TP1-38/nav-settings
Apr 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robdivincenzo
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @jhonatan-lopes 👍
1d76c60
into
feature-branch/main-nav-dropdown
6 checks passed
jhonatan-lopes
added a commit
that referenced
this pull request
Apr 4, 2024
* Better panels on NavMenu * Add SiteNavMenu setting * Show only default locale nav menus on settings * Fix donate banner test * Add title and locale to NavDropdownFactory * Remove print statements
jhonatan-lopes
added a commit
that referenced
this pull request
Apr 18, 2024
* Better panels on NavMenu * Add SiteNavMenu setting * Show only default locale nav menus on settings * Fix donate banner test * Add title and locale to NavDropdownFactory * Remove print statements
jhonatan-lopes
added a commit
that referenced
this pull request
Apr 29, 2024
* Better panels on NavMenu * Add SiteNavMenu setting * Show only default locale nav menus on settings * Fix donate banner test * Add title and locale to NavDropdownFactory * Remove print statements
➤ Simon Acosta Torres commented: PR has already been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add settings to define a navigation menu for a site.
Link to sample test page:
Related PRs/issues:
Checklist
Tests
Changes in Models:
Documentation:
[ ] Did I update the READMEs or wagtail documentation?Merge Method
💡❗Remember to use squash merge when merging non-feature branches into
main
┆Issue is synchronized with this Jira Story