Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TP1-38][Main Nav] Nav Settings #12137

Merged

Conversation

jhonatan-lopes
Copy link
Contributor

@jhonatan-lopes jhonatan-lopes commented Apr 3, 2024

Description

Add settings to define a navigation menu for a site.

Link to sample test page:
Related PRs/issues:

Checklist

Tests

  • Is the code I'm adding covered by tests?

Changes in Models:

  • Did I update or add new fake data?
  • Did I squash my migration?
  • Are my changes backward-compatible. If not, did I schedule a deploy with the rest of the team?

Documentation:

  • Is my code documented?
  • [ ] Did I update the READMEs or wagtail documentation?

Merge Method
💡❗Remember to use squash merge when merging non-feature branches into main

┆Issue is synchronized with this Jira Story

Copy link
Collaborator

@robdivincenzo robdivincenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @jhonatan-lopes 👍

@jhonatan-lopes jhonatan-lopes merged commit 1d76c60 into feature-branch/main-nav-dropdown Apr 4, 2024
6 checks passed
@jhonatan-lopes jhonatan-lopes deleted the feature/TP1-38/nav-settings branch April 4, 2024 14:48
jhonatan-lopes added a commit that referenced this pull request Apr 4, 2024
* Better panels on NavMenu

* Add SiteNavMenu setting

* Show only default locale nav menus on settings

* Fix donate banner test

* Add title and locale to NavDropdownFactory

* Remove print statements
jhonatan-lopes added a commit that referenced this pull request Apr 18, 2024
* Better panels on NavMenu

* Add SiteNavMenu setting

* Show only default locale nav menus on settings

* Fix donate banner test

* Add title and locale to NavDropdownFactory

* Remove print statements
jhonatan-lopes added a commit that referenced this pull request Apr 29, 2024
* Better panels on NavMenu

* Add SiteNavMenu setting

* Show only default locale nav menus on settings

* Fix donate banner test

* Add title and locale to NavDropdownFactory

* Remove print statements
@data-sync-user
Copy link
Collaborator

➤ Simon Acosta Torres commented:

PR has already been merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants