added donate landing and help page to percy tests

[danielfmiranda]

Description

Link to sample test page:
Related PRs/issues: #11174

This PR adds the Donate Landing Page and Donate Help Page to the list of pages to be checked by Percy. That way we can flag any unintended changes to the donate pages in future updates!

Please note that this change does not include the donate "Ways to give" page as there is currently no factory, and also, that page is built using the "default page" model. However, ticket #11497 has been created to capture that work/discussion 👍

[danielfmiranda]

Leaving a note before the holiday break:

I am able to get the recaptcha box for the donate help form consistently on percy's chrome screenshots.

However for some reason, the box does not render on percys screenshots using FireFox 🤔

I have tried the following things in visual.spec.js, all which produce the "render on chrome, but not on firefox" issue:

• Wait for Iframe to be visible, scroll Iframe into view, wait 2s
• Wait for Iframe to be visible, scroll Iframe into view, and wait 3s
• Wait for Iframe to be visible, wait for Iframes recaptcha label to load in, wait 2s
• Scroll to bottom of page, wait for iframe and recaptcha label, scroll into view, scroll to top, wait 2s

Whats interesting to me is that the await statements that wait for the recaptcha box/label do not fail. I have double checked and if the recaptcha box was really not rendering, these statements would return an error during the CI tests.

Going to bring this up to discuss with other devs after the break, to see if we want to dedicate more time to getting the recaptcha box to render on FF.

[danielfmiranda]

Hi Everyone!

As mentioned in the comment above, we now have the recaptcha box consistently rendering as expected on Percy's screenshots for Google Chrome:

On FireFox screenshots, the page content and spacing consistently renders as if the recaptcha box is there, and, JavaScript that is awaiting the Recaptcha's inner iframe contents to be loaded in is also not failing. The only difference is that the recaptcha box is not being shown in the screenshot for some reason:

After discussion with @mtdenton, we have decided that this work is good to go as is.

Submitting for review!

[mtdenton]

LGTM!