-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump RxMoya's watchOS deployment target to 3.0 #1758
Conversation
Hey @SimonRice, yes we should bump the version in the podspec as well 👍 Could you please add a CHANGELOG entry under Changed to convey this to users? |
Please Merge Pull Request Right now!!! |
You could always use a fork in the meantime, @gityubj :) |
b4f8ffc
to
66e27f7
Compare
Generated by 🚫 Danger |
Codecov Report
@@ Coverage Diff @@
## development #1758 +/- ##
============================================
Coverage 90.83% 90.83%
============================================
Files 5 5
Lines 131 131
============================================
Hits 119 119
Misses 12 12 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just letting CI pass 👍 Thanks for updating this @SimonRice
@SimonRice Thanks a lot for contributing to Moya! We've invited you to join Generated by 🚫 dangerJS |
This PR fixes an issue I encountered when building RxMoya for watchOS via Carthage from both development & master on Xcode 10.1.
RxSwift's watchOS deployment target is now at watchOS 3.0 in v4.4.0. As a result, RxMoya fails to build for watchOS via Carthage since its deployment target is at watchOS 2.0. This PR bumps RxMoya's watchOS deployment target to match RxSwift's, allowing a successful build via Carthage.
All other OS deployment targets appear to be fine.
Question: should the sub-podspec for RxMoya also be bumped to watchOS 3.0?