Memory leak fixes #1285
Merged
Memory leak fixes #1285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was not properly clearing the field storageManager, which in turn was still referencing the entity manager.
The liquid wrapper references indirectly the entity manager. So not disposing it caused a big memory leak.
…ads creating chunks. Otherwise the chunk monitor can end up with references to chunks, after the chunk provider disposal is done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes some memory leaks:
After starting a game and returning to the main menu the memory usage reported by the Eclipse Memory Analyzer was about 80 MB. With this fixes the reported memory usage in the same situation is now about 12 MB.