Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added GitHub Authorisation Tutorial to docs folder #75

Merged
merged 6 commits into from
Jan 21, 2019

Conversation

evanhearne
Copy link
Collaborator

I am adding this tutorial as I think it will benefit the newcomers to this project in the future.

Description

New tutorial on how to authorize your computer for work on github has been added to the /docs folder. It has been added so that people will know how to authorize their computers for work on this project.

What

A tutorial that wasn't previously available has been added for learning and teaching use.

Why

This tutorial has been added because it will benefit future project workers, in my opinion. They will have easy access to a step-by-step process that will inevitably remove some stress from the setting up and continuation of the project.

How

The ODF file was uploaded via GitHub and was added to a branch.

Verification Steps

-Download file
-Open it using OpenOffice, LibreOffice, or Microsoft Office.
-Ensure all slides are present
-Leave a review or request below

Checklist:

  • This pr is linked to the related trello card
  • My code follows the style guidelines of this project
  • I have requested a code review from (at least) two team members
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • This change has been verified by another team member

I am adding this tutorial as I think it will benefit the newcomers to this project in the future.
@evanhearne
Copy link
Collaborator Author

evanhearne commented Jan 11, 2019 via email

Copy link
Contributor

@laurafitzgerald laurafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @evanhearne To make things easier for the user and consistent with the other files in the docs/ folder can you translate the steps to markdown?

@evanhearne
Copy link
Collaborator Author

@laurafitzgerald conversion is completed. Please review when you have the time.

Copy link
Contributor

@laurafitzgerald laurafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanhearne thanks for adding this as markdown file. You can go ahead and remove the odp file now. Could you check the formatting of the md file. There is some funny numbering going on. You can view the file by going to Files changed -> View File

@evanhearne
Copy link
Collaborator Author

evanhearne commented Jan 16, 2019 via email

@evanhearne
Copy link
Collaborator Author

@laurafitzgerald could you explain to me what you meant by 'numbering' ? I'm not sure I understand.

@evanhearne
Copy link
Collaborator Author

@laurafitzgerald whatever issues I found with the document, I believe they're solved now. Step 3 won't become a title for me for some reason.

@evanhearne
Copy link
Collaborator Author

@laurafitzgerald changes requested have been completed, please review when you have the time.

Copy link
Contributor

@laurafitzgerald laurafitzgerald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanhearne thanks for adding the steps. There's some content in there that you could have linked out to. e.g. link to where you add ssh keys in github and/or links to where it explains how to generate ssh keys as it may vary by OS. They are only minor however and I will leave it up to you whether you want to do that or not. Feel free to merge it if you are happy with it. :) Thanks for the change.

@evanhearne
Copy link
Collaborator Author

@laurafitzgerald I will make said changes as even though they're minor, little things can make a big difference.

@evanhearne
Copy link
Collaborator Author

@laurafitzgerald because @edkennedy50 wants as many changes made as possible to this master before you have a video conference on Wednesday, I will adjust the title to suit this for Fedora.

@evanhearne evanhearne merged commit 9f2bf78 into master Jan 21, 2019
@evanhearne evanhearne deleted the evanhearne-github-tutorial branch January 21, 2019 09:38
@laurafitzgerald
Copy link
Contributor

@evanhearne that's no problem, could you create a card on the backlog to do the additional work to cover Windows. You can label it setup and link to this pr to show the source of the work

@evanhearne
Copy link
Collaborator Author

@laurafitzgerald done. Can you please review AUP Policy PR for me and @SinenWew? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants