Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add M1 support #75

Merged
merged 5 commits into from
Dec 6, 2022
Merged

Add M1 support #75

merged 5 commits into from
Dec 6, 2022

Conversation

MordechaiHadad
Copy link
Owner

@MordechaiHadad MordechaiHadad commented Dec 4, 2022

fix #22

@MordechaiHadad
Copy link
Owner Author

@Allaman is this a proper m1 build? like does it work?

@Allaman
Copy link

Allaman commented Dec 4, 2022

@MordechaiHadad when I download https://github.com/MordechaiHadad/bob/suites/9654259823/artifacts/461831526 (from https://github.com/MordechaiHadad/bob/actions/runs/3612423509) I'll get a x86_64 executable despite its name being bob-macos-arm. This confirms the fact that bob-macos-arm and bob-macos-x86_64 are of equal size.
(It still works for me because I have Rosetta2 enabled)

@MordechaiHadad
Copy link
Owner Author

@Allaman I see tell me how it is for the new build

@MordechaiHadad
Copy link
Owner Author

nvm they failedb hmm

@MordechaiHadad
Copy link
Owner Author

@Allaman test the new builds when you are free to do so!

@Allaman
Copy link

Allaman commented Dec 5, 2022

@MordechaiHadad
Copy link
Owner Author

@Allaman What the fuck lmaooooo
That doesn't make sense, the build fails if I don't download the m1 target but if i do it works fine...
sus I will have to look more into this

@MordechaiHadad
Copy link
Owner Author

@Allaman can u perhaps download the m1 download from here and do the same checking u do in the comment?
https://github.com/dandavison/delta/releases/tag/0.15.1

no need to use it or something, just to see if its the same or whatever

@Allaman
Copy link

Allaman commented Dec 5, 2022

@MordechaiHadad sure :)
image

PS: It's part of my tooling already ;)

@MordechaiHadad
Copy link
Owner Author

this is really weird
thank you

@MordechaiHadad
Copy link
Owner Author

Seems like my theory about wrong path was correct
@Allaman can you try one last time?

@Allaman
Copy link

Allaman commented Dec 6, 2022

@MordechaiHadad looking good !
image

@MordechaiHadad
Copy link
Owner Author

@MordechaiHadad looking good !
image

Ayyy thank you very much for the help!

@Allaman
Copy link

Allaman commented Dec 6, 2022

Your are welcome!

@MordechaiHadad MordechaiHadad merged commit 0005446 into master Dec 6, 2022
@MordechaiHadad MordechaiHadad deleted the ci/m1 branch December 7, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Darwin ARM build for M1 devices
2 participants