Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: added missing 'normalizeMetadata' param #905

Merged
merged 5 commits into from
Dec 20, 2022

Conversation

Y0moo
Copy link
Contributor

@Y0moo Y0moo commented Dec 19, 2022


name: 'Pull request'
about: A new pull request

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

Issue Description

In some places, the parameter "normalizeMetadata" was missing

@Y0moo Y0moo self-assigned this Dec 19, 2022
@changeset-bot
Copy link

changeset-bot bot commented Dec 19, 2022

🦋 Changeset detected

Latest commit: 33230c4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 27 packages
Name Type
@moralisweb3/common-evm-utils Patch
@moralisweb3/api-utils Patch
@moralisweb3/auth Patch
@moralisweb3/codegen Patch
@moralisweb3/evm-api Patch
@moralisweb3/evm-utils Patch
@moralisweb3/next Patch
@moralisweb3/parse-server Patch
@moralisweb3/sol-api Patch
@moralisweb3/sol-utils Patch
@moralisweb3/streams Patch
@moralisweb3/test-utils Patch
@moralisweb3/common-auth-utils Patch
@moralisweb3/common-core Patch
@moralisweb3/common-sol-utils Patch
@moralisweb3/common-streams-utils Patch
@moralisweb3/client-api-utils Patch
@moralisweb3/client-evm-api Patch
@moralisweb3/client-firebase-api-utils Patch
@moralisweb3/client-firebase-auth-utils Patch
@moralisweb3/client-firebase-evm-api Patch
@moralisweb3/client-firebase-evm-auth Patch
@moralisweb3/client-firebase-sol-api Patch
@moralisweb3/client-firebase-sol-auth Patch
@moralisweb3/client-sol-api Patch
moralis Patch
create-moralis-dapp Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Y0moo Y0moo changed the title fix: added missing 'normalizeMetadata' param Fix: added missing 'normalizeMetadata' param Dec 19, 2022
@Y0moo Y0moo requested a review from b4rtaz December 19, 2022 14:12
FedericoAmura
FedericoAmura previously approved these changes Dec 19, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2022

Test coverage

Title Lines Statements Branches Functions
api-utils Coverage: 25%
26.34% (49/186) 19.14% (9/47) 22.85% (8/35)
auth Coverage: 90%
92.77% (77/83) 81.81% (18/22) 90% (18/20)
evm-api Coverage: 100%
100% (80/80) 66.66% (6/9) 100% (48/48)
common-evm-utils Coverage: 64%
64.99% (947/1457) 19.43% (123/633) 35.8% (203/567)
sol-api Coverage: 96%
96.66% (29/30) 66.66% (6/9) 91.66% (11/12)
common-sol-utils Coverage: 74%
73.77% (135/183) 60% (12/20) 65.67% (44/67)
common-streams-utils Coverage: 93%
93.96% (1027/1093) 81.15% (392/483) 86.74% (360/415)
streams Coverage: 87%
86.82% (402/463) 67.6% (48/71) 84.52% (71/84)

Copy link
Collaborator

@b4rtaz b4rtaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not updated *OperationTest.ts files.

@Y0moo
Copy link
Contributor Author

Y0moo commented Dec 19, 2022

Not updated *OperationTest.ts files.

Thank you @b4rtaz. Your eagle eye saves, as always!

@Y0moo Y0moo requested a review from b4rtaz December 19, 2022 14:34
@b4rtaz
Copy link
Collaborator

b4rtaz commented Dec 19, 2022

@Y0moo haha! 🦅 My eagle eyes see that, there is not a changeset.

@Y0moo Y0moo requested a review from FedericoAmura December 20, 2022 07:27
@Y0moo Y0moo merged commit 5b641a4 into main Dec 20, 2022
@Y0moo Y0moo deleted the fix-missing-url-params-in-serialize-func branch December 20, 2022 09:17
@github-actions github-actions bot mentioned this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants