Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename api endpoints. #646

Merged
merged 10 commits into from
Sep 6, 2022
Merged

rename api endpoints. #646

merged 10 commits into from
Sep 6, 2022

Conversation

b4rtaz
Copy link
Collaborator

@b4rtaz b4rtaz commented Sep 1, 2022

name: rename api endpoints.

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

@changeset-bot
Copy link

changeset-bot bot commented Sep 1, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: d17131b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@moralisweb3/evm-api Patch
moralis Patch
@moralisweb3/core Patch
@moralisweb3/auth Patch
@moralisweb3/api-utils Patch
@moralisweb3/evm-utils Patch
@moralisweb3/sol-utils Patch
@moralisweb3/sol-api Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@b4rtaz b4rtaz marked this pull request as ready for review September 2, 2022 09:31
@b4rtaz b4rtaz requested review from ErnoW and sogunshola September 2, 2022 09:31
sogunshola
sogunshola reviewed Sep 2, 2022
View reviewed changes
Copy link
Contributor

@sogunshola sogunshola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good.

This triggers a lot of docs update also. is there progress with that? anything I can help with?

@b4rtaz
Copy link
Collaborator Author

b4rtaz commented Sep 2, 2022

This triggers a lot of docs update also. is there progress with that? anything I can help with?

This task doesn't have a docs part. We need to add docs for all endpoints, but I think that should be planned in a next task (here we have too many changes).

ErnoW
ErnoW requested changes Sep 6, 2022
View reviewed changes
packages/apiUtils/src/utils/tryGetNextPageParams.ts Outdated Show resolved Hide resolved
packages/evmApi/src/EvmApi.ts Show resolved Hide resolved
packages/evmApi/src/EvmApi.ts Outdated Show resolved Hide resolved
packages/evmApi/src/EvmApi.ts Outdated Show resolved Hide resolved
packages/integration/mockRequests/evmApi/endpointWeights.ts Outdated Show resolved Hide resolved
packages/evmApi/src/EvmApi.ts Show resolved Hide resolved
packages/evmApi/src/EvmApi.ts Show resolved Hide resolved
.changeset/chatty-donkeys-boil.md Outdated Show resolved Hide resolved
@b4rtaz b4rtaz requested a review from ErnoW September 6, 2022 11:55
@b4rtaz b4rtaz enabled auto-merge (squash) September 6, 2022 12:01
@b4rtaz b4rtaz merged commit 7bf5ec6 into main Sep 6, 2022
@b4rtaz b4rtaz deleted the rename-api-endpoints branch September 6, 2022 12:04
@github-actions github-actions bot mentioned this pull request Sep 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogunshola sogunshola sogunshola left review comments

@ErnoW ErnoW ErnoW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b4rtaz @ErnoW @sogunshola