docs: added technical docs to EvmTransaction datatype #614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8cc2d21 The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…into docs/evmTransaction
…into docs/evmTransaction
b4rtaz
requested changes
Aug 25, 2022
Comment on lines
38
to
40
| /** | ||
| * Internal reference of the transaction. | ||
| */ |
There was a problem hiding this comment.
We should not comment private fields.
Comment on lines
11
to
31
| * const transactionInput = { | ||
| cumulativeGasUsed: "1340925", | ||
| gasPrice: "20000000000", | ||
| gasUsed: "1340925", | ||
| index: "25", | ||
| contractAddress: "0x1d6a4cf64b52f6c73f201839aded7379ce58059c", | ||
| receiptRoot: "string", | ||
| receiptStatus: "1", | ||
| chain: "1", | ||
| data: transaction.input, | ||
| from: "0xd4a3BebD824189481FC45363602b83C9c7e9cbDf", | ||
| hash: "0x057Ec652A4F150f7FF94f089A38008f49a0DF88e", | ||
| nonce: "326595425", | ||
| value: "650000000000000000", | ||
| blockHash: transaction.block_hash, | ||
| blockNumber: "12526958", | ||
| blockTimestamp: new Date("2021-04-02T10:07:54.000Z"), | ||
| gas: "6721975", | ||
| to: "0xa71db868318f0a0bae9411347cd4a6fa23d8d4ef", | ||
| } | ||
| * ``` |
There was a problem hiding this comment.
Have you checked how this part looks in the output docs? Here you don't have * in each line. Maybe it's correct.
There was a problem hiding this comment.
Yes. it looks like this.
There was a problem hiding this comment.
Pushed request changes
packages/evmUtils/src/dataTypes/EvmTransaction/EvmTransaction.ts
Outdated
Show resolved
Hide resolved
…into docs/evmTransaction
b4rtaz
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
name: 'Pull request'
about: A new pull request
New Pull Request
Checklist
Issue Description
Related issue: #
FILL_THIS_OUTSolution Description