Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(big number): own implementation of BigNumber #535

Merged
merged 8 commits into from
Jul 27, 2022
Merged

feat(big number): own implementation of BigNumber #535

merged 8 commits into from
Jul 27, 2022

Conversation

b4rtaz
Copy link
Collaborator

@b4rtaz b4rtaz commented Jul 26, 2022

name: own implementation of BigNumber

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

@changeset-bot
Copy link

changeset-bot bot commented Jul 26, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: d032d64

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@moralisweb3/api-utils Major
@moralisweb3/evm-api Major
@moralisweb3/integration Major
test-node Patch
@moralisweb3/auth Major
@moralisweb3/core Major
@moralisweb3/evm-utils Major
moralis Patch
@moralisweb3/sol-api Major
@moralisweb3/sol-utils Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@b4rtaz b4rtaz marked this pull request as ready for review July 26, 2022 11:02
@b4rtaz b4rtaz requested review from ErnoW and sogunshola July 26, 2022 11:02
@b4rtaz b4rtaz enabled auto-merge (squash) July 26, 2022 11:16
ErnoW
ErnoW requested changes Jul 27, 2022
View reviewed changes
Copy link
Member

@ErnoW ErnoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, only a few comments to make it more consistent with our other data types

packages/core/src/dataTypes/BigNumber/BigNumber.ts Outdated Show resolved Hide resolved
packages/core/src/dataTypes/BigNumber/BigNumber.ts Outdated Show resolved Hide resolved
sogunshola
sogunshola reviewed Jul 27, 2022
View reviewed changes
Copy link
Contributor

@sogunshola sogunshola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@b4rtaz b4rtaz requested a review from ErnoW July 27, 2022 09:14
@b4rtaz b4rtaz merged commit 279507c into alpha Jul 27, 2022
@b4rtaz b4rtaz deleted the feat/big-number branch July 27, 2022 11:15
@github-actions github-actions bot mentioned this pull request Jul 27, 2022
Merged
@github-actions github-actions bot mentioned this pull request Aug 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sogunshola sogunshola sogunshola left review comments

@ErnoW ErnoW ErnoW approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@b4rtaz @ErnoW @sogunshola