test(api): api package test + few adjustments #518
Conversation
🦋 Changeset detectedLatest commit: 3d68a63 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -0,0 +1,27 @@ | |||
| /* eslint-disable no-console */ | |||
There was a problem hiding this comment.
I think this test should be in the packages/integration package.
packages/api/src/test/setup.ts
Outdated
| } | ||
| } | ||
|
|
||
| const mockServer = setupServer(mockEndpointWeights, mockGetContractEvents); |
There was a problem hiding this comment.
I think this is not the best way how it could be tested. We already have integration tests, so I think we don't need a next integration test package. You can here mock responses by jest.spyOn(axios, 'request') instead using the msw server.
There was a problem hiding this comment.
good suggestion. on it
| const callSpy = jest.fn(async () => await resolver.next()); | ||
| const result = await callSpy(); |
There was a problem hiding this comment.
This is unnecessary. jest.fn() should be used only in case, when you need to test some logic inside a testing class/function.
packages/api/src/test/setup.ts
Outdated
| }; | ||
| }[]; | ||
|
|
||
| export class MockApi extends ApiModule { |
There was a problem hiding this comment.
I think this is not the best way to test ApiResolver. Tests should be small as possible. Here you want to test ApiResolver, but you have additionally config/modules etc. If you had an error in modules, you will get an error in ApiResolver tests. That is wrong.
I recommend move this test to packages/api/src/Resolver.test.ts, and test only ApiResolver without modules.
name: API package test
New Pull Request
Checklist
Issue Description
Related issue: #
FILL_THIS_OUTSolution Description