Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cdn builds): usage in browsers via a script tag #469

Merged
merged 16 commits into from
Jul 4, 2022
Merged

Conversation

b4rtaz
Copy link
Collaborator

@b4rtaz b4rtaz commented Jul 1, 2022


name: CDN builds
about: Usage in browsers via a script tag

New Pull Request

Checklist

  • I am not disclosing a vulnerability.
  • My code is conform the code style
  • I have made corresponding changes to the documentation
  • I have updated Typescript definitions when needed

@b4rtaz b4rtaz requested review from ErnoW and sogunshola July 1, 2022 08:03
@changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2022

🦋 Changeset detected

Latest commit: 3eccbc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
@moralisweb3/core Patch
@moralisweb3/evm Patch
@moralisweb3/evm-api Patch
@moralisweb3/evm-connector-utils Patch
@moralisweb3/evm-metamask-connector Patch
@moralisweb3/evm-wallet-connect-connector Patch
@moralisweb3/wallet-connect-wrapper Patch
@moralisweb3/integration Patch
moralis Patch
@moralisweb3/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@ErnoW ErnoW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. I have left a few questions.

Also main issue currently is that the CDN test app does not work.
I run yarn and yarn build following by yarn e2e(in test-cdn). But I get the error:

"GET /packages/moralis/dist/index.umd.js" Error (404): "Not found"

Which seems correct, as no index.umd.js file has been created during yarn build

.vscode/settings.json Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
demos/test-app-all/package.json Outdated Show resolved Hide resolved
demos/test-app-all/package.json Outdated Show resolved Hide resolved
demos/test-cdn/package.json Show resolved Hide resolved
packages/core/package.json Show resolved Hide resolved
packages/moralis/src/index.ts Show resolved Hide resolved
@b4rtaz b4rtaz requested a review from ErnoW July 4, 2022 10:31
@ErnoW ErnoW merged commit 9e67989 into alpha Jul 4, 2022
@ErnoW ErnoW deleted the feat/cdn-build branch July 4, 2022 12:18
@github-actions github-actions bot mentioned this pull request Jul 4, 2022
@github-actions github-actions bot mentioned this pull request Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants