Add is_on_curve hint and basic test #1

notlesh · 2024-01-31T18:11:22Z

Adds the is_on_curve SNOS hint.

notlesh · 2024-01-31T18:14:17Z

src/hints/mod.rs

+    // TODO: assume SECP_P is in scope, or should we use this constant?
+    // let SECP_P = cairo_vm::hint_processor::builtin_hint_processor::secp::secp_utils::SECP_P;
+    let SECP_P: BigInt = exec_scopes.get("SECP_P")?;


It's not clear from the hint whether this should have been injected into exec_scopes from some other code/hint or if it should just exist implicitly.

In any case, the constant mentioned (cairo_vm::hint_processor::builtin_hint_processor::secp::secp_utils::SECP_P) is private.

From other hints defined in cairo-vm (see here) it seems that SECP_P should be inserted at some point in the execution scope but is also a constant in the VM.

src/hints/mod.rs

src/hints/tests.rs

src/hints/mod.rs

odesenfans · 2024-02-05T15:20:15Z

src/hints/mod.rs

+    _constants: &HashMap<String, Felt252>,
+) -> Result<(), HintError> {
+    let y: BigInt = exec_scopes.get("y")?;
+    // TODO: should y_square_int be calculated or should caller put it in scope for us?


Given the context, y_square_int is just a variable in exec_scopes. Looking at cairo-lang, I think it is set in ec.cairo.

I don't see it in ec.cairo, can you point me to where you see that?

src/hints/mod.rs

odesenfans · 2024-02-05T15:21:53Z

src/hints/mod.rs

+    // constant)?
+    let secp_p: BigInt = exec_scopes.get("SECP_P")?;
+
+    let is_on_curve = (y.clone() * y) % secp_p == y_square_int;


Is that clone() required? Is BigInt not a Copy type?

BigInt doesn't impl Copy probably because it is arbitrarily large, so clone() is required.

* Add is_on_curve hint and basic test * Improve test * Add TODO * Update Cargo.lock * Attempt at better ids_data * Set fp and add another segment * Clean up * fmt * Fix clippy lints * fmt * fmt * Add IS_ON_CURVE to hints map * Use constants for ONE and ZERO * fmt * Clean up secp_p comments * Use vars for var names * Remove duplicate mod tests

* wip * wip, some progress * WIP: Declare unimplemented hints * Fix unused warnings * Hint: SET_SYSCALL_PTR (#4) * Add is_n_ge_two hint (#3) * first iteration of is_n_ge_two hint * refactor is_n_ge_two hint. remove unused dependencies. start test * set vm memory in test * remove unused macros * fix test and remove debugging prints * add EOF line * add test cases * use rstest cases. refactor hint code to avoid using match. rename hint tests module. * apply formatter * add case for n > two * remove End of file line * run fmt+nightly command * run fmt+nightly command * add hint in hint map and use ids map (#6) * add hint in hint map and use ids map * remove unused macro. makes hint constant public * Add is_on_curve hint and basic test (#1) * Add is_on_curve hint and basic test * Improve test * Add TODO * Update Cargo.lock * Attempt at better ids_data * Set fp and add another segment * Clean up * fmt * Fix clippy lints * fmt * fmt * Add IS_ON_CURVE to hints map * Use constants for ONE and ZERO * fmt * Clean up secp_p comments * Use vars for var names * Remove duplicate mod tests * Add set_ap_to_actual_fee hint (#2) Co-authored-by: Olivier Desenfans <[email protected]> Co-authored-by: Herman Obst Demaestri <[email protected]> * Add txn/call hints (#5) Co-authored-by: Olivier Desenfans <[email protected]> * Add preimage hints (#8) Co-authored-by: Olivier Desenfans <[email protected]> * Feature: read/write Cairo structs safely (#9) Problem: Cairo structs are accessed in some hints. The Python VM has abstractions to access fields by name that the Rust VM cannot implement. This leads to accessing these structs by hardcoding the offset of each field. Solution: The new `CairoType` trait allows to read/write an entire struct in one go. The derive implementation reads/writes fields one by one according to their place in the struct definition. For cases where reading/writing the whole struct is not appropriate, the new `FieldOffsetGetters` macro implements a `get_<field>_offset()` method for each field of the struct to avoid hardcoding values. * fix tests * one more hint * fix contracts in StarknetOsInput * few more hints * ignore block test * Add a couple missing hints * calculate tx_hash * fix TRANSACTIONS_LEN * Maybe-fix gen_signature_arg hint * Don't put signature in ap * remove unnecesary unwraps * fix post merge problems * remove outdated tests * is_reverted hint * wip * Pull in relevant hashing code from starknet_on_rust * Convert equivalent contract structs * wip * test with cairo1 * cairo1 test setup, breaks at hint trying to load v1 class * wip * wip * cairo1 class loading + execution without cairo1 hint processor * fix tests * fix clippy * first round of comments * fix typo * remove unnecessary code --------- Co-authored-by: Olivier Desenfans <[email protected]> Co-authored-by: Herman Obst Demaestri <[email protected]> Co-authored-by: Stephen Shelton <[email protected]>

* wip * wip, some progress * WIP: Declare unimplemented hints * Fix unused warnings * Hint: SET_SYSCALL_PTR (#4) * Add is_n_ge_two hint (#3) * first iteration of is_n_ge_two hint * refactor is_n_ge_two hint. remove unused dependencies. start test * set vm memory in test * remove unused macros * fix test and remove debugging prints * add EOF line * add test cases * use rstest cases. refactor hint code to avoid using match. rename hint tests module. * apply formatter * add case for n > two * remove End of file line * run fmt+nightly command * run fmt+nightly command * add hint in hint map and use ids map (#6) * add hint in hint map and use ids map * remove unused macro. makes hint constant public * Add is_on_curve hint and basic test (#1) * Add is_on_curve hint and basic test * Improve test * Add TODO * Update Cargo.lock * Attempt at better ids_data * Set fp and add another segment * Clean up * fmt * Fix clippy lints * fmt * fmt * Add IS_ON_CURVE to hints map * Use constants for ONE and ZERO * fmt * Clean up secp_p comments * Use vars for var names * Remove duplicate mod tests * Add set_ap_to_actual_fee hint (#2) Co-authored-by: Olivier Desenfans <[email protected]> Co-authored-by: Herman Obst Demaestri <[email protected]> * Add txn/call hints (#5) Co-authored-by: Olivier Desenfans <[email protected]> * Add preimage hints (#8) Co-authored-by: Olivier Desenfans <[email protected]> * Feature: read/write Cairo structs safely (#9) Problem: Cairo structs are accessed in some hints. The Python VM has abstractions to access fields by name that the Rust VM cannot implement. This leads to accessing these structs by hardcoding the offset of each field. Solution: The new `CairoType` trait allows to read/write an entire struct in one go. The derive implementation reads/writes fields one by one according to their place in the struct definition. For cases where reading/writing the whole struct is not appropriate, the new `FieldOffsetGetters` macro implements a `get_<field>_offset()` method for each field of the struct to avoid hardcoding values. * fix tests * one more hint * fix contracts in StarknetOsInput * few more hints * ignore block test * Add a couple missing hints * calculate tx_hash * fix TRANSACTIONS_LEN * Maybe-fix gen_signature_arg hint * Don't put signature in ap * remove unnecesary unwraps * fix post merge problems * remove outdated tests * is_reverted hint * wip * Pull in relevant hashing code from starknet_on_rust * Convert equivalent contract structs * wip * test with cairo1 * cairo1 test setup, breaks at hint trying to load v1 class * wip * wip * cairo1 class loading + execution without cairo1 hint processor * fix tests * fix clippy * first round of comments * wip * cairo1 syscall handler * fix imports * fix fmt, clippy * fix clippy * fix fmt --------- Co-authored-by: Olivier Desenfans <[email protected]> Co-authored-by: Herman Obst Demaestri <[email protected]> Co-authored-by: Stephen Shelton <[email protected]>

notlesh added 2 commits January 31, 2024 10:55

Add is_on_curve hint and basic test

9196e3d

Improve test

a8fb4a8

notlesh commented Jan 31, 2024

View reviewed changes

src/hints/mod.rs Outdated Show resolved Hide resolved

notlesh commented Jan 31, 2024

View reviewed changes

src/hints/tests.rs Outdated Show resolved Hide resolved

notlesh added 6 commits January 31, 2024 14:13

Add TODO

ab142e0

Update Cargo.lock

3a24dfd

Attempt at better ids_data

38b3ead

Set fp and add another segment

6cb1079

Clean up

eae0a8b

Merge branch 'msl/hints' into notlesh/is_on_curve_hint

4468bfc

notlesh requested a review from odesenfans February 2, 2024 17:10

fmt

c1fec6f

notlesh commented Feb 2, 2024

View reviewed changes

src/hints/tests.rs Outdated Show resolved Hide resolved

Fix clippy lints

3649c82

odesenfans suggested changes Feb 5, 2024

View reviewed changes

notlesh added 8 commits February 5, 2024 10:22

Merge branch 'msl/hints' into notlesh/is_on_curve_hint

fb004c4

fmt

10224e1

fmt

aa50757

Add IS_ON_CURVE to hints map

63bb84d

Use constants for ONE and ZERO

ca2677b

fmt

3aec1ec

Clean up secp_p comments

3eb2c41

Use vars for var names

f9bc365

notlesh requested a review from odesenfans February 5, 2024 18:05

notlesh added 3 commits February 5, 2024 11:40

Merge branch 'msl/hints' into notlesh/is_on_curve_hint

cd121e6

Remove duplicate mod tests

d9d37c1

Merge branch 'msl/hints' into notlesh/is_on_curve_hint

6eecc28

odesenfans approved these changes Feb 5, 2024

View reviewed changes

notlesh merged commit c6443ff into Moonsong-Labs:msl/hints Feb 5, 2024
5 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add is_on_curve hint and basic test #1

Add is_on_curve hint and basic test #1

notlesh commented Jan 31, 2024 •

edited

Loading

notlesh Jan 31, 2024

odesenfans Feb 5, 2024

odesenfans Feb 5, 2024

notlesh Feb 5, 2024

odesenfans Feb 5, 2024

notlesh Feb 5, 2024

Add is_on_curve hint and basic test #1

Add is_on_curve hint and basic test #1

Conversation

notlesh commented Jan 31, 2024 • edited Loading

notlesh Jan 31, 2024

Choose a reason for hiding this comment

odesenfans Feb 5, 2024

Choose a reason for hiding this comment

odesenfans Feb 5, 2024

Choose a reason for hiding this comment

notlesh Feb 5, 2024

Choose a reason for hiding this comment

odesenfans Feb 5, 2024

Choose a reason for hiding this comment

notlesh Feb 5, 2024

Choose a reason for hiding this comment

notlesh commented Jan 31, 2024 •

edited

Loading