-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v0.2.0 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rockacola
requested changes
Nov 28, 2019
@@ -201,17 +200,15 @@ export class AsteroidUser { | |||
/** | |||
* @returns ID of the newly created task | |||
*/ | |||
async createTask(taskType: string, taskVersion: string, taskPriority: number, target: string): Promise<string> { | |||
async createTask(taskType: string, taskVersion: string, taskPriority: number, payload: object): Promise<string> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this been further specified rather then a generic object
type?
For example, will this interface definition works:
interface CreateTaskPayload {
target: string
}
And the method declaration will then becomes:
async createTask(taskType: string, taskVersion: string, taskPriority: number, payload: CreateTaskPayload): Promise<string> {
Purpose of this, is to providing typing guidance on what's the expectation for the variable payload
.
Currently the payload object is unstructured so there is no further
definition that can be implemented.
…On Wed, Nov 27, 2019, 10:00 PM Travis ***@***.***> wrote:
Assigned #10 <#10> to
@lllwvlvwlll <https://github.com/lllwvlvwlll>.
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#10?email_source=notifications&email_token=AHDLEEETI44KTSWGXUSGSYDQV5F57A5CNFSM4JSNSZZ2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVERZ43Q#event-2837683822>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AHDLEEHXBW3S443I2JUYLH3QV5F57ANCNFSM4JSNSZZQ>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
profile_type
tocreateProfile
andgetOwnedProfileHeaders
claims worker
andsystem testing
to use the sdkgetProfileByToken
from asteroid-user to asteroid (does not require a user login for use)secret
or admin-levelaccess_token
createTask
with asteroid-domain-worker usagegetUnclaimedTask
to target the correct asteroid domain