Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom http transport #586

Merged
merged 2 commits into from
Jan 22, 2021
Merged

custom http transport #586

merged 2 commits into from
Jan 22, 2021

Conversation

bundleman
Copy link
Contributor

I added option WithCustomTransport for http driver and did refactoring code which create pester.Client.

Added WithCustomTransport was necessary for control flag InsecureSkipVerify in section TLSClientConfig inside http.Transport.

p.s. it is PR after review #585 (comment)

@codecov
Copy link

codecov bot commented Jan 22, 2021

Codecov Report

Merging #586 (fa2be4b) into master (dd0e9ee) will increase coverage by 0.2%.
The diff coverage is 66.7%.

@@           Coverage Diff            @@
##           master    #586     +/-   ##
========================================
+ Coverage    42.2%   42.4%   +0.2%     
========================================
  Files         268     268             
  Lines        8089    8098      +9     
========================================
+ Hits         3416    3437     +21     
+ Misses       4307    4295     -12     
  Partials      366     366             

@ziflex ziflex merged commit 8d7f1da into MontFerret:master Jan 22, 2021
@ziflex
Copy link
Member

ziflex commented Jan 22, 2021

Thanks for your PR!

@bundleman bundleman deleted the http-transport branch April 5, 2021 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants