Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added possibility to load pages from memory #434

Merged
merged 2 commits into from
Jan 4, 2020
Merged

Added possibility to load pages from memory #434

merged 2 commits into from
Jan 4, 2020

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Dec 26, 2019

Closes #385

@ziflex ziflex added type/enhancement New feature or request area/stdlib Standard library issue area/drivers/cdp Cdp driver area/drivers/http Http driver area/drivers HTML drivers labels Dec 26, 2019
@ziflex ziflex requested a review from 3timeslazy December 26, 2019 17:46
@codecov
Copy link

codecov bot commented Dec 26, 2019 •
edited
Loading

Codecov Report

Merging #434 into master will decrease coverage by 0.1%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master    #434     +/-   ##
========================================
- Coverage    41.8%   41.7%   -0.1%     
========================================
  Files         227     227             
  Lines        8756    8759      +3     
========================================
- Hits         3660    3652      -8     
- Misses       4742    4750      +8     
- Partials      354     357      +3

3timeslazy
3timeslazy suggested changes Dec 29, 2019
View reviewed changes
pkg/stdlib/html/parse.go Show resolved Hide resolved
pkg/stdlib/html/parse.go Outdated Show resolved Hide resolved
@ziflex ziflex requested a review from 3timeslazy December 30, 2019 16:06
@ziflex ziflex merged commit 4af0e0f into master Jan 4, 2020
@ziflex ziflex deleted the feature/#385-page-from-memory branch January 4, 2020 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3timeslazy 3timeslazy Awaiting requested review from 3timeslazy

Assignees
No one assigned
Labels
area/drivers/cdp Cdp driver area/drivers/http Http driver area/drivers HTML drivers area/stdlib Standard library issue type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Load HTML pages from memory
2 participants
@ziflex @3timeslazy