Bugfix/#399 navigation #432
Conversation
# Conflicts: # go.mod # go.sum
ziflex
added
area/stdlib
Codecov Report
@@ Coverage Diff @@
## master #432 +/- ##
========================================
+ Coverage 39.4% 41.7% +2.3%
========================================
Files 222 227 +5
Lines 9096 8756 -340
========================================
+ Hits 3585 3654 +69
+ Misses 5154 4746 -408
+ Partials 357 356 -1 |
| ) | ||
|
|
||
| type ( | ||
| DocumentUpdatedListener func(ctx context.Context) |
There was a problem hiding this comment.
Add comment to all types below please.
pkg/drivers/cdp/events/listener.go
Outdated
| } | ||
| ) | ||
|
|
||
| // Many is a helper function that tells event loop to always call the function |
| } | ||
|
|
||
| // Many is a helper function that tells event loop to call the function only once | ||
| func Once(fn func(ctx context.Context, message interface{})) Handler { |
| lc.mu.Lock() | ||
| defer lc.mu.Unlock() | ||
|
|
||
| bucket, exists := lc.values[eventID] |
There was a problem hiding this comment.
Go allows you to delete key from the map without any checks.
Example: https://play.golang.org/p/yHhJIsYHkm6
There was a problem hiding this comment.
Yes, but i'm not deleting it from lc.values. I'm deleting in from a nested map.
| "github.com/mafredri/cdp/rpcc" | ||
| ) | ||
|
|
||
| type ( |
There was a problem hiding this comment.
Add comment to all types below please.
| ) | ||
|
|
||
| var ( | ||
| Error = New("error") |
pkg/drivers/cookies.go
Outdated
|
|
||
| oc := other.(HTTPCookies) | ||
|
|
||
| if len(c) > len(oc) { |
There was a problem hiding this comment.
switch-case seems to be more readable
switch {
case len(c) > len(oc):
return 1
case len(c) < len(oc):
return -1
}There was a problem hiding this comment.
Maybe? I didn't know that you can omit switch expression.
|
|
||
| var emptyExpires = time.Time{} | ||
|
|
||
| func parseAttrs(attrs []string) *values.Object { |
There was a problem hiding this comment.
I don’t quite understand what is going on here
There was a problem hiding this comment.
CDP returns HTML attributes as an array of strings of key-value pairs. This methods parses the array and converts it into an object.
Big changes!
Refactored the way how we deal with frames and network events: