Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#291 param dot notation #378

Merged
merged 4 commits into from
Sep 7, 2019
Merged

Feature/#291 param dot notation #378

merged 4 commits into from
Sep 7, 2019

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Sep 7, 2019

Closes #291

@ziflex ziflex added type/enhancement New feature or request area/compiler Compiler issue area/parser Parser issue area/syntax FQL syntax issue area/runtime Runtime issue labels Sep 7, 2019
golangcibot
golangcibot reviewed Sep 7, 2019
View reviewed changes
pkg/runtime/expressions/member.go Outdated
@@ -35,22 +35,24 @@ func (e *MemberExpression) Exec(ctx context.Context, scope *core.Scope) (core.Va
)
}

strPath := make([]core.Value, len(e.path))
out := val
path := make([]core.Value, 1, 1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

S1019: should use make([]core.Value, 1) instead (from gosimple)

@codecov
Copy link

codecov bot commented Sep 7, 2019 •
edited
Loading

Codecov Report

Merging #378 into master will decrease coverage by 0.1%.
The diff coverage is 53.5%.

@@           Coverage Diff           @@
##           master   #378     +/-   ##
=======================================
- Coverage    39.1%    39%   -0.1%     
=======================================
  Files         218    218             
  Lines        8873   8939     +66     
=======================================
+ Hits         3473   3488     +15     
- Misses       5046   5095     +49     
- Partials      354    356      +2

@ziflex ziflex merged commit 926cc30 into master Sep 7, 2019
@ziflex ziflex deleted the feature/#291-param-dot-notation branch September 7, 2019 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

Assignees
No one assigned
Labels
area/compiler Compiler issue area/parser Parser issue area/runtime Runtime issue area/syntax FQL syntax issue type/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use bind parameters for the dot notation
2 participants
@ziflex @golangcibot