Added INPUT_CLEAR function #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golangcibot
reviewed
Aug 30, 2019
pkg/drivers/cdp/input/keyboard.go
Outdated
| @@ -33,14 +63,14 @@ func (k *Keyboard) Up(ctx context.Context, char string) error { | |||
| } | |||
|
|
|||
| func (k *Keyboard) Type(ctx context.Context, text string, delay int) error { | |||
| for _, ch := range text { | |||
| for _, ch := range []rune(text) { | |||
There was a problem hiding this comment.
S1029: should range over string, not []rune(string) (from gosimple)
Codecov Report
@@ Coverage Diff @@
## master #366 +/- ##
========================================
- Coverage 39.7% 39.7% -0.1%
========================================
Files 218 218
Lines 8721 8747 +26
========================================
+ Hits 3465 3469 +4
- Misses 4905 4926 +21
- Partials 351 352 +1 |
|
closes #362 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.