Added possibility to set custom viewport size #334

ziflex · 2019-07-16T22:53:21Z

Added new settings:

LET p = DOCUMENT(url, {
    driver: "cdp",
    viewport: {
        width: 1024,
        height: 768,
        landscape: false,
        mobile: false,
        scaleFactor: 1
   }
})

golangcibot · 2019-07-16T22:56:51Z

pkg/drivers/cdp/driver.go

@@ -20,6 +20,11 @@ const DriverName = "cdp"
 const BlankPageURL = "about:blank"
 const DefaultTimeout = 5000 * time.Millisecond

+var defaultScreenSize = &drivers.ScreenSize{


defaultScreenSize is unused (from deadcode)

3timeslazy · 2019-07-17T11:57:19Z

pkg/drivers/cdp/page.go

+		},
+
+		func() error {
+			if params.Screen != nil {


Make

if params.Screen == nil { return nil }

first pls

codecov · 2019-07-17T16:21:57Z

Codecov Report

Merging #334 into master will decrease coverage by <.1%.
The diff coverage is 5.7%.

@@           Coverage Diff            @@
##           master    #334     +/-   ##
========================================
- Coverage    39.7%   39.7%   -<.1%     
========================================
  Files         217     217             
  Lines        8563    8587     +24     
========================================
+ Hits         3401    3410      +9     
- Misses       4809    4825     +16     
+ Partials      353     352      -1

Added possibility to set custom viewport size

2eb0879

ziflex requested a review from 3timeslazy July 16, 2019 22:53

golangcibot reviewed Jul 16, 2019

View reviewed changes

Fixed linting issue

64d2bfe

3timeslazy suggested changes Jul 17, 2019

View reviewed changes

ziflex added 2 commits July 17, 2019 11:53

Merge branch 'master' into refactoring/screen-size

f3d34a5

Renamed ScreenSize to Viewport

efae765

Updated e2e test

a774887

ziflex merged commit 6320114 into master Jul 17, 2019

ziflex deleted the refactoring/screen-size branch July 17, 2019 17:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added possibility to set custom viewport size #334

Added possibility to set custom viewport size #334

ziflex commented Jul 16, 2019 •

edited

Loading

golangcibot Jul 16, 2019

3timeslazy Jul 17, 2019

codecov bot commented Jul 17, 2019 •

edited

Loading

Added possibility to set custom viewport size #334

Added possibility to set custom viewport size #334

Conversation

ziflex commented Jul 16, 2019 • edited Loading

golangcibot Jul 16, 2019

Choose a reason for hiding this comment

3timeslazy Jul 17, 2019

Choose a reason for hiding this comment

codecov bot commented Jul 17, 2019 • edited Loading

Codecov Report

ziflex commented Jul 16, 2019 •

edited

Loading

codecov bot commented Jul 17, 2019 •

edited

Loading