Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/#293 regular exp operator #326

Merged
merged 3 commits into from
Jul 9, 2019
Merged

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Jul 9, 2019

  • =~ positive matching
  • !~ negative matching

@ziflex ziflex added area/compiler Compiler issue area/parser Parser issue area/syntax FQL syntax issue area/runtime Runtime issue labels Jul 9, 2019
@ziflex ziflex requested a review from 3timeslazy July 9, 2019 16:29
pkg/compiler/visitor.go Outdated Show resolved Hide resolved
Copy link
Member

@3timeslazy 3timeslazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about flags e.g.

  • g (global) - don't return after first match
  • m (multiline) - ^ and $ match start/end of line
  • i (insensitive) - case insensitive match
  • u (ungreedy) - make quantifiers lazy
    ?

@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #326 into master will decrease coverage by 0.3%.
The diff coverage is 36.5%.

@@           Coverage Diff            @@
##           master    #326     +/-   ##
========================================
- Coverage    39.8%   39.5%   -0.3%     
========================================
  Files         215     216      +1     
  Lines        8513    8698    +185     
========================================
+ Hits         3384    3433     +49     
- Misses       4775    4907    +132     
- Partials      354     358      +4

@ziflex
Copy link
Member Author

ziflex commented Jul 9, 2019

What about flags e.g.

  • g (global) - don't return after first match
  • m (multiline) - ^ and $ match start/end of line
  • i (insensitive) - case insensitive match
  • u (ungreedy) - make quantifiers lazy
    ?

It supports everything that is supported by Regexp.MatchString.

@ziflex ziflex merged commit cf43c7f into master Jul 9, 2019
@ziflex ziflex deleted the feature/#293-regular-exp-operator branch July 10, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compiler Compiler issue area/parser Parser issue area/runtime Runtime issue area/syntax FQL syntax issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants