Feature/#229 wait no element #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #249 +/- ##
======================================
Coverage 60.1% 60.1%
======================================
Files 179 179
Lines 5296 5296
======================================
Hits 3184 3184
Misses 1763 1763
Partials 349 349 |
3timeslazy
suggested changes
Mar 6, 2019
| } | ||
| ) | ||
|
|
||
| const ( | ||
| WaitEventPresence = 0 |
There was a problem hiding this comment.
add comments for WaitEventPresenceand WaitEventAbsence pls :)
| } | ||
| } | ||
|
|
||
| if found == values.False { |
There was a problem hiding this comment.
add comment explaining why values.True returns here.
3timeslazy
pushed a commit
to 3timeslazy/ferret
that referenced
this pull request
Apr 10, 2019
* Added possibility to wait for an element or a class absence
3timeslazy
pushed a commit
to 3timeslazy/ferret
that referenced
this pull request
Apr 10, 2019
* Added possibility to wait for an element or a class absence
3timeslazy
pushed a commit
to 3timeslazy/ferret
that referenced
this pull request
Apr 10, 2019
* Added possibility to wait for an element or a class absence
3timeslazy
pushed a commit
to 3timeslazy/ferret
that referenced
this pull request
Apr 10, 2019
* Added possibility to wait for an element or a class absence
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #229
Added