Feature/#236 cookies #242
Merged
Feature/#236 cookies #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3timeslazy
suggested changes
Mar 2, 2019
README.md
Outdated
| #### CLI | ||
|
|
||
| ```sh | ||
| ferret --cdp-keep-cookies my-query.fql |
There was a problem hiding this comment.
remove left spaces pls
ferret --cdp-keep-cookies my-query.fql
pkg/drivers/cdp/helpers.go
Outdated
| switch cookie.SameSite { | ||
| case http.SameSiteLaxMode: | ||
| sameSite = network.CookieSameSiteLax | ||
| break |
There was a problem hiding this comment.
break can be removed, because break is a default behavior of switch-case
| switch c.SameSite { | ||
| case network.CookieSameSiteLax: | ||
| sameSite = http.SameSiteLaxMode | ||
| break |
There was a problem hiding this comment.
break can be removed, because break is a default behavior of switch-case
3timeslazy
suggested changes
Mar 2, 2019
pkg/drivers/cookie.go
Outdated
|
|
||
| MaxAge int `json:"max_age"` | ||
| Secure bool `json:"secure"` | ||
| HttpOnly bool `json:"http_only"` |
pkg/drivers/cdp/helpers.go
Outdated
| cookie.Expires = time.Now().Add(time.Duration(24) + time.Hour) | ||
| } | ||
|
|
||
| normalizedUrl := normalizeCookieUrl(url) |
There was a problem hiding this comment.
Use normalizedURL instead of normalizedUrl
3timeslazy
suggested changes
Mar 3, 2019
examples/cookies.go
Outdated
|
|
||
| import ( | ||
| "context" | ||
| "encoding/json" |
examples/cookies.go
Outdated
| ) | ||
|
|
||
| return program.Run(ctx) | ||
| } |
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
========================================
- Coverage 56.7% 56.3% -0.5%
========================================
Files 189 189
Lines 5696 5749 +53
========================================
+ Hits 3231 3235 +4
- Misses 2114 2164 +50
+ Partials 351 350 -1 |
3timeslazy
pushed a commit
to 3timeslazy/ferret
that referenced
this pull request
Apr 10, 2019
* Added KeepCookies option to CDP driver * Added LoadDocumentParams * Added COOKIE_GET and COOKIE_SET methods
3timeslazy
pushed a commit
to 3timeslazy/ferret
that referenced
this pull request
Apr 10, 2019
author Tim Voronov <[email protected]> 1552622815 -0400 committer Владимир Фетисов <[email protected]> 1554919032 +0300 parent b45f889 author Tim Voronov <[email protected]> 1552622815 -0400 committer Владимир Фетисов <[email protected]> 1554919029 +0300 Updated style template Feature/MontFerret#236 cookies (MontFerret#242) * Added KeepCookies option to CDP driver * Added LoadDocumentParams * Added COOKIE_GET and COOKIE_SET methods Updated CHANGELOG Updated nav example fix order of arguments (MontFerret#269) Updated RAND function (MontFerret#271) * Updated RAND function * renamed a func Linter Cleanup (MontFerret#276) * linter cleanup * fix default case Bump github.com/mafredri/cdp from 0.22.0 to 0.23.0 (MontFerret#278) Bumps [github.com/mafredri/cdp](https://github.com/mafredri/cdp) from 0.22.0 to 0.23.0. - [Release notes](https://github.com/mafredri/cdp/releases) - [Commits](mafredri/cdp@v0.22.0...v0.23.0) Signed-off-by: dependabot[bot] <[email protected]> fix diff
3timeslazy
pushed a commit
to 3timeslazy/ferret
that referenced
this pull request
Apr 10, 2019
* Added KeepCookies option to CDP driver * Added LoadDocumentParams * Added COOKIE_GET and COOKIE_SET methods
3timeslazy
pushed a commit
to 3timeslazy/ferret
that referenced
this pull request
Apr 10, 2019
author Tim Voronov <[email protected]> 1552622815 -0400 committer Владимир Фетисов <[email protected]> 1554919032 +0300 parent b45f889 author Tim Voronov <[email protected]> 1552622815 -0400 committer Владимир Фетисов <[email protected]> 1554919029 +0300 Updated style template Feature/MontFerret#236 cookies (MontFerret#242) * Added KeepCookies option to CDP driver * Added LoadDocumentParams * Added COOKIE_GET and COOKIE_SET methods Updated CHANGELOG Updated nav example fix order of arguments (MontFerret#269) Updated RAND function (MontFerret#271) * Updated RAND function * renamed a func Linter Cleanup (MontFerret#276) * linter cleanup * fix default case Bump github.com/mafredri/cdp from 0.22.0 to 0.23.0 (MontFerret#278) Bumps [github.com/mafredri/cdp](https://github.com/mafredri/cdp) from 0.22.0 to 0.23.0. - [Release notes](https://github.com/mafredri/cdp/releases) - [Commits](mafredri/cdp@v0.22.0...v0.23.0) Signed-off-by: dependabot[bot] <[email protected]> fix diff
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236