Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed dot notation for HTML elements #239

Merged
merged 6 commits into from
Feb 26, 2019
Merged

Fixed dot notation for HTML elements #239

merged 6 commits into from
Feb 26, 2019

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Feb 24, 2019

el.attributes.href

returns attributes object instead of url.

@ziflex ziflex added the area/drivers HTML drivers label Feb 24, 2019
@ziflex ziflex requested a review from 3timeslazy February 24, 2019 01:29
@codecov
Copy link

codecov bot commented Feb 24, 2019

Codecov Report

Merging #239 into master will not change coverage.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           master    #239   +/-   ##
======================================
  Coverage    60.1%   60.1%           
======================================
  Files         179     179           
  Lines        5296    5296           
======================================
  Hits         3183    3183           
+ Misses       1764    1763    -1     
- Partials      349     350    +1

Copy link
Member

@3timeslazy 3timeslazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Go part of code: 👍🏿
Other: 👍

@ziflex ziflex merged commit 63dfcde into master Feb 26, 2019
@ziflex ziflex deleted the bug/html-attrs branch February 26, 2019 04:33
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Fixed dot notation for HTML elements
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Fixed dot notation for HTML elements
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Fixed dot notation for HTML elements
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Fixed dot notation for HTML elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/drivers HTML drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants