Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Context to HTML methods #235

Merged
merged 4 commits into from
Feb 21, 2019
Merged

Added Context to HTML methods #235

merged 4 commits into from
Feb 21, 2019

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Feb 20, 2019

No description provided.

@ziflex ziflex added area/drivers/cdp Cdp driver area/drivers/http Http driver area/drivers HTML drivers labels Feb 20, 2019
@ziflex ziflex requested a review from 3timeslazy February 20, 2019 03:25
Copy link
Member

@3timeslazy 3timeslazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is OK, except for the fallen build.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #235 into master will increase coverage by 0.1%.
The diff coverage is 13.6%.

@@           Coverage Diff            @@
##           master    #235     +/-   ##
========================================
+ Coverage    58.8%   58.9%   +0.1%     
========================================
  Files         179     179             
  Lines        5262    5263      +1     
========================================
+ Hits         3093    3101      +8     
+ Misses       1823    1817      -6     
+ Partials      346     345      -1

@ziflex ziflex merged commit 6e15846 into master Feb 21, 2019
@ziflex ziflex deleted the refactoring/html-context branch February 21, 2019 02:24
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Added Context to HTML methods

* Fixed unit tests

* Updated timeout

* Fixed WAIT_CLASS timeout
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Added Context to HTML methods

* Fixed unit tests

* Updated timeout

* Fixed WAIT_CLASS timeout
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Added Context to HTML methods

* Fixed unit tests

* Updated timeout

* Fixed WAIT_CLASS timeout
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
* Added Context to HTML methods

* Fixed unit tests

* Updated timeout

* Fixed WAIT_CLASS timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/drivers/cdp Cdp driver area/drivers/http Http driver area/drivers HTML drivers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants