Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New type system #232

Merged
merged 3 commits into from
Feb 13, 2019
Merged

New type system #232

merged 3 commits into from
Feb 13, 2019

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Feb 13, 2019

Now Type is an interface.

@ziflex ziflex added area/runtime Runtime issue area/stdlib Standard library issue area/drivers HTML drivers labels Feb 13, 2019
@ziflex ziflex requested a review from 3timeslazy February 13, 2019 00:51
@codecov
Copy link

codecov bot commented Feb 13, 2019 •
edited
Loading

Codecov Report

Merging #232 into master will increase coverage by 0.1%.
The diff coverage is 64.7%.

@@           Coverage Diff            @@
##           master    #232     +/-   ##
========================================
+ Coverage    59.2%   59.3%   +0.1%     
========================================
  Files         180     181      +1     
  Lines        5252    5236     -16     
========================================
- Hits         3109    3103      -6     
+ Misses       1800    1787     -13     
- Partials      343     346      +3

3timeslazy
3timeslazy approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@3timeslazy 3timeslazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👌✊

3timeslazy
3timeslazy approved these changes Feb 13, 2019
View reviewed changes
Copy link
Member

@3timeslazy 3timeslazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👌✊

@ziflex ziflex merged commit 1af8b37 into master Feb 13, 2019
@ziflex ziflex deleted the feature/new-type-system branch February 13, 2019 19:27
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
@ziflex
New type system (MontFerret#232)
2995d1d 
* New type system

* Fixed dot notation for HTML elements
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
@ziflex
New type system (MontFerret#232)
2bc81d4 
* New type system

* Fixed dot notation for HTML elements
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
@ziflex
New type system (MontFerret#232)
71c4b33 
* New type system

* Fixed dot notation for HTML elements
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
@ziflex
New type system (MontFerret#232)
e26b7b2 
* New type system

* Fixed dot notation for HTML elements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3timeslazy 3timeslazy 3timeslazy approved these changes

Assignees
No one assigned
Labels
area/drivers HTML drivers area/runtime Runtime issue area/stdlib Standard library issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziflex @3timeslazy