Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ELEMENT_EXISTS function #210

Merged
merged 1 commit into from
Dec 19, 2018
Merged

Added ELEMENT_EXISTS function #210

merged 1 commit into from
Dec 19, 2018

Conversation

ziflex
Copy link
Member

@ziflex ziflex commented Dec 18, 2018

No description provided.

@ziflex ziflex requested a review from 3timeslazy December 18, 2018 01:16
@codecov
Copy link

codecov bot commented Dec 18, 2018 •
edited
Loading

Codecov Report

Merging #210 into next will decrease coverage by 0.1%.
The diff coverage is 0%.

@@          Coverage Diff           @@
##           next    #210     +/-   ##
======================================
- Coverage    59%   58.9%   -0.1%     
======================================
  Files       180     180             
  Lines      5230    5235      +5     
======================================
  Hits       3085    3085             
- Misses     1805    1809      +4     
- Partials    340     341      +1

3timeslazy
3timeslazy reviewed Dec 18, 2018
View reviewed changes
e2e/main.go
if *filter != "" {
r, err := regexp.Compile(*filter)

if err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think would be better to use regexp.MustCompile(*filter) instead.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would panic the app without a proper message.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will.

3timeslazy
3timeslazy reviewed Dec 18, 2018
View reviewed changes
e2e/main.go
"github.com/MontFerret/ferret/e2e/runner"
"github.com/MontFerret/ferret/e2e/server"
"github.com/rs/zerolog"
"os"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you can use goimports util.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3timeslazy Could you give me more details on that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/bradfitz/goimports

3timeslazy
3timeslazy reviewed Dec 18, 2018
View reviewed changes
pkg/drivers/cdp/element.go
return values.False
}

return values.True
Copy link
Member

@3timeslazy 3timeslazy Dec 18, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about return values.NewBoolean(res.NodeID != 0)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@3timeslazy what about code readability? :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

¯_(ツ)_/¯

3timeslazy
3timeslazy reviewed Dec 18, 2018
View reviewed changes
pkg/drivers/http/element.go
return values.False
}

return values.True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same with this.

3timeslazy
3timeslazy reviewed Dec 18, 2018
View reviewed changes
Copy link
Member

@3timeslazy 3timeslazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

@ziflex ziflex merged commit 7ca57c5 into next Dec 19, 2018
@ziflex ziflex deleted the feature/element-exists branch December 19, 2018 01:18
ziflex added a commit that referenced this pull request Dec 22, 2018
@ziflex
Next (#214)
5620be2 
* Renamed DOCUMENT to PAGE

* Added PageLoadParams

* Added PageLoadParams

* Renamed LoadPageParams -> PageLoadParams

* Added support for context.Done() (#201)

* Bug/#189 operators precedence (#202)

* Fixed math operators precedence

* Fixed logical operators precedence

* Fixed array operator

* Added support for parentheses to enforce a different operator evaluation order

* Feature/#200 drivers (#209)

* Added new interfaces

* Renamed dynamic to cdp driver

* Renamed drivers

* Added ELEMENT_EXISTS function (#210)

* Renamed back PAGE to DOCUMENT (#211)

* Added Getter and Setter interfaces
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
@ziflex
Next (MontFerret#214)
36514c8 
* Renamed DOCUMENT to PAGE

* Added PageLoadParams

* Added PageLoadParams

* Renamed LoadPageParams -> PageLoadParams

* Added support for context.Done() (MontFerret#201)

* Bug/MontFerret#189 operators precedence (MontFerret#202)

* Fixed math operators precedence

* Fixed logical operators precedence

* Fixed array operator

* Added support for parentheses to enforce a different operator evaluation order

* Feature/MontFerret#200 drivers (MontFerret#209)

* Added new interfaces

* Renamed dynamic to cdp driver

* Renamed drivers

* Added ELEMENT_EXISTS function (MontFerret#210)

* Renamed back PAGE to DOCUMENT (MontFerret#211)

* Added Getter and Setter interfaces
3timeslazy pushed a commit to 3timeslazy/ferret that referenced this pull request Apr 10, 2019
@ziflex
Next (MontFerret#214)
207d9d0 
* Renamed DOCUMENT to PAGE

* Added PageLoadParams

* Added PageLoadParams

* Renamed LoadPageParams -> PageLoadParams

* Added support for context.Done() (MontFerret#201)

* Bug/MontFerret#189 operators precedence (MontFerret#202)

* Fixed math operators precedence

* Fixed logical operators precedence

* Fixed array operator

* Added support for parentheses to enforce a different operator evaluation order

* Feature/MontFerret#200 drivers (MontFerret#209)

* Added new interfaces

* Renamed dynamic to cdp driver

* Renamed drivers

* Added ELEMENT_EXISTS function (MontFerret#210)

* Renamed back PAGE to DOCUMENT (MontFerret#211)

* Added Getter and Setter interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3timeslazy 3timeslazy 3timeslazy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziflex @3timeslazy