Sqla14 improvements #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o sqla14_improvements
|
that was quick. the test suite doesn't complete though :) |
|
@gijzelaerr that's definitely not all 😅. i just wanted to merge so i can have separate branches for different fixes e.g. JSON support. it would takes us some time to address (most of) the issues |
|
what I would do is disable the test/error tests for now, and then work yourself down the list of tests by enabling them one by one. That way you can use the CICD to catch regression bugs. |
|
that's the idea. we will also merge tomorrow Mitchel's branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of sqlalchemy 1.4 improvements.