Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

model_diagnostics returns error when y_hat is of array class #319

Closed
hbaniecki opened this issue Sep 4, 2020 · 0 comments · Fixed by #320
Closed

model_diagnostics returns error when y_hat is of array class #319

hbaniecki opened this issue Sep 4, 2020 · 0 comments · Fixed by #320
Assignees
Labels
invalid ❕ This doesn't seem right, potential bug R 🐳 Related to R

Comments

@hbaniecki
Copy link
Member

We could potentialy make model_diagnostics() more robust to different y_hat class.

if (is.null(dim(explainer$y_hat))) {
results$y_hat <- explainer$y_hat
} else {
results$y_hat <- explainer$y_hat[, 1] # this will work only for first column
}

image

@hbaniecki hbaniecki added the R 🐳 Related to R label Sep 4, 2020
@hbaniecki hbaniecki changed the title model_diagnostics returns error when y_hat is of class array model_diagnostics returns error when y_hat is of array class Sep 4, 2020
@hbaniecki hbaniecki added the invalid ❕ This doesn't seem right, potential bug label Sep 4, 2020
hbaniecki added a commit that referenced this issue Sep 4, 2020
@hbaniecki hbaniecki self-assigned this Sep 4, 2020
pbiecek pushed a commit that referenced this issue Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid ❕ This doesn't seem right, potential bug R 🐳 Related to R
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant