Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #93

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Improve CI #93

merged 2 commits into from
Dec 14, 2023

Conversation

daxpedda
Copy link
Collaborator

@daxpedda daxpedda commented Dec 14, 2023

  • Don't run CI on every push, but only on the main branch and in PRs.
  • Cancel CI when a new one is already run on a newer commit.
  • Use CARGO_TERM_COLOR.
  • Use taiki-e/install-action.
  • Make sure to always checkout the repo first, which avoids some issues, like running actions.
  • Add Typos for spell checking.

@daxpedda daxpedda requested a review from ModProg December 14, 2023 10:43
.github/workflows/test.yml Outdated Show resolved Hide resolved
@ModProg
Copy link
Owner

ModProg commented Dec 14, 2023

Did you try both versions?

The second one should only add the msrv: true right?

As 1.57.0 is then part of the default matrix?

@daxpedda
Copy link
Collaborator Author

Ah, I see, didn't pay close attention.
That works indeed.

@daxpedda daxpedda merged commit 3602c57 into ModProg:main Dec 14, 2023
67 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants