Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 649 search screen back and forward browsers actions reacting on typying #660

Conversation

qcdyx
Copy link
Contributor

@qcdyx qcdyx commented Aug 6, 2024

Summary:
Closes #649
update the URL query params only when the search action is dispatched, rather than with each character typed.

Expected behavior:
search for new york in feeds screen, click back navigation button in the browser, it goes back to the previous page instead of removing the previous keystroke.

Testing tips:

Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Add or update any needed documentation to the repo
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@qcdyx qcdyx linked an issue Aug 6, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Aug 6, 2024

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-660-zmzna09k.web.app

@davidgamez
Copy link
Member

The initial search query from the home page is not set in the search query input, but the subsequence text is properly kept in it. The attached screen capture shows this.

Screen.Recording.2024-08-06.at.4.42.48.PM.mov

…lls 2. search query in home page is copied over to the text fields of feeds search page
@Alessandro100
Copy link
Contributor

If we do a search and go back it wont update the search results. This also happens with pagination.

Expected result: If we go back, the data on the page should reflect the current url

Screen.Recording.2024-08-12.at.11.21.42.mov

@qcdyx
Copy link
Contributor Author

qcdyx commented Aug 12, 2024

I forgot to mention that there's a bug where the result page doesn't change when the back navigation button is clicked. This issue also occurs on the main branch. I suggest creating a new issue to track this. @emmambd I'm currently working on the URL change and using a single state variable. @Alessandro100 @davidgamez

@davidgamez
Copy link
Member

I forgot to mention that there's a bug where the result page doesn't change when the back navigation button is clicked. This issue also occurs on the main branch. I suggest creating a new issue to track this. @emmambd I'm currently working on the URL change and using a single state variable. @Alessandro100 @davidgamez

I checked in QA and the pagination issue is present, let's keep it outside this PR as @qcdyx suggested.

@qcdyx
Copy link
Contributor Author

qcdyx commented Aug 12, 2024

#667 @emmambd

Copy link
Contributor

@Alessandro100 Alessandro100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, intuitive way of triggering the search ✅

@qcdyx qcdyx merged commit 9f6000e into main Aug 13, 2024
4 checks passed
@qcdyx qcdyx deleted the 649-search-screen-back-and-forward-browsers-actions-reacting-on-typying branch August 13, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search screen back and forward browser's actions reacting on typying
3 participants