-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: 649 search screen back and forward browsers actions reacting on typying #660
fix: 649 search screen back and forward browsers actions reacting on typying #660
Conversation
Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-660-zmzna09k.web.app |
The initial search query from the home page is not set in the search query input, but the subsequence text is properly kept in it. The attached screen capture shows this. Screen.Recording.2024-08-06.at.4.42.48.PM.mov |
…lls 2. search query in home page is copied over to the text fields of feeds search page
If we do a search and go back it wont update the search results. This also happens with pagination. Expected result: If we go back, the data on the page should reflect the current url Screen.Recording.2024-08-12.at.11.21.42.mov |
I forgot to mention that there's a bug where the result page doesn't change when the back navigation button is clicked. This issue also occurs on the main branch. I suggest creating a new issue to track this. @emmambd I'm currently working on the URL change and using a single state variable. @Alessandro100 @davidgamez |
I checked in QA and the pagination issue is present, let's keep it outside this PR as @qcdyx suggested. |
…actions-reacting-on-typying
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, intuitive way of triggering the search ✅
Summary:
Closes #649
update the URL query params only when the search action is dispatched, rather than with each character typed.
Expected behavior:
search for new york in feeds screen, click back navigation button in the browser, it goes back to the previous page instead of removing the previous keystroke.
Testing tips:
Provide tips, procedures and sample files on how to test the feature.
Testers are invited to follow the tips AND to try anything they deem relevant outside the bounds of the testing tips.
Please make sure these boxes are checked before submitting your pull request - thanks!
./scripts/api-tests.sh
to make sure you didn't break anything