Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Review firebase rule to make sure it aligns with API's password rules #191

Merged
merged 7 commits into from
Dec 5, 2023

Conversation

cka-y
Copy link
Contributor

@cka-y cka-y commented Nov 30, 2023

Summary:

Update Firebase password policy to reflect the API's policy: https://cloud.google.com/identity-platform/docs/password-policy
Extracted from #141

Closes #188

image

Expected behavior:
The firebase password policy should be the same as the web app password policy

Testing tips:

  • Reset your password
  • The criteria to save your new password should be the same as the one from the app (i.e. Password must contain at least one uppercase letter, one lowercase letter, one digit, one special char(!@#$%^&*) and be at least 12 chars long)

Note: special char in Firebase include ^ $ * . [ ] { } ( ) ? " ! @ # % & / \ , > < ' : ; | _ ~ ` which is more characters than we allow in our app -- Introduced Fix: Allow more special char within our app

Please make sure these boxes are checked before submitting your pull request - thanks!

  • Run the unit tests with ./scripts/api-tests.sh to make sure you didn't break anything
  • Format the title like "feat: [new feature short description]". Title must follow the Conventional Commit Specification(https://www.conventionalcommits.org/en/v1.0.0/).
  • Linked all relevant issues
  • Include screenshot(s) showing how this pull request works and fixes the issue(s)

@cka-y cka-y changed the title Feat/188 feat: Review firebase rule to make sure it aligns with API's password rules Nov 30, 2023
Copy link

Preview Firebase Hosting URL: https://mobility-feeds-dev--pr-191-gz6twrrn.web.app

@cka-y cka-y marked this pull request as ready for review November 30, 2023 21:21
@cka-y cka-y requested a review from davidgamez November 30, 2023 21:21
@cka-y cka-y marked this pull request as draft December 1, 2023 14:22
@cka-y cka-y marked this pull request as ready for review December 5, 2023 14:54
Copy link
Member

@davidgamez davidgamez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cka-y cka-y merged commit 2e2ee03 into main Dec 5, 2023
@cka-y cka-y deleted the feat/188 branch December 5, 2023 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review firebase rule to make sure it aligns with API's password rules
2 participants