New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Website/Readme: Fix url placeholder and random typos #42

Merged

PierrickP merged 2 commits into MobilityData:master from nextbike:fix_url_placeholder

Oct 21, 2021

Contributor

nbdh commented Oct 20, 2021 •

edited

Loading

The placeholder URL is also visible on the screenshot in the readme, but I guess it'll be updated with the next major change which I'd expect to be sufficient.

Apropos readme, probably not the right place to bring this up: The Contributing chapter could contain a comment about / link to the CLA contributors are apparently required to sign.

nbdh and others added 2 commits

October 20, 2021 12:28


          fix(website): typo in placeholder URL

e75599a


          fix(readme): fix some typos

b7c1885

netlify bot commented Oct 20, 2021 •

edited

Loading

❌ Deploy Preview for competent-payne-690ca9 failed.

🔨 Explore the source changes: b7c1885

🔍 Inspect the deploy log: https://app.netlify.com/sites/competent-payne-690ca9/deploys/617006b33289a100070f420f

netlify bot commented Oct 20, 2021 •

edited

Loading

✔️ Deploy Preview for unruffled-hugle-914373 ready!

🔨 Explore the source changes: b7c1885

🔍 Inspect the deploy log: https://app.netlify.com/sites/unruffled-hugle-914373/deploys/617006b471c21d0008392268

😎 Browse the preview: https://deploy-preview-42--unruffled-hugle-914373.netlify.app/

netlify bot commented Oct 20, 2021 •

edited

Loading

❌ Deploy Preview for wizardly-lichterman-770f54 failed.

🔨 Explore the source changes: b7c1885

🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-lichterman-770f54/deploys/617006b3d0d7b8000875e490

netlify bot commented Oct 20, 2021 •

edited

Loading

❌ Deploy Preview for wizardly-engelbart-5c48ca failed.

🔨 Explore the source changes: b7c1885

🔍 Inspect the deploy log: https://app.netlify.com/sites/wizardly-engelbart-5c48ca/deploys/617006b473b2ee0007d8b87d

netlify bot commented Oct 20, 2021 •

edited

Loading

❌ Deploy Preview for kind-pike-a3f3f8 failed.

🔨 Explore the source changes: b7c1885

🔍 Inspect the deploy log: https://app.netlify.com/sites/kind-pike-a3f3f8/deploys/617006b477246d00079f8638

Collaborator

PierrickP commented Oct 21, 2021

Thanks for the PR.
I let @isabelle-dr answer / make a PR for the CLA

PierrickP merged commit 7f6210b into MobilityData:master

This was referenced Oct 21, 2021

Update web interface screenshot on README.md #43

Merged

Add link to the CLA in the contribution guidelines #44

Open

Contributor

isabelle-dr commented Oct 21, 2021

Thank you for this contribution @nbdh!
The screenshot has been updated in #43, and I just created an issue for adding the CLA link in the contribution guidelines.

Have a great day!

Contributor Author

nbdh commented Oct 28, 2021

Awesome, thank you for taking care of that @isabelle-dr and @PierrickP.

Could you perhaps also have a look at issue #41?

Have a great day, too!

nbdh deleted the fix_url_placeholder branch

October 28, 2021 09:45

Contributor

isabelle-dr commented Oct 28, 2021

👋

Could you perhaps also have a look at issue #41?

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet