Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type from number to integer #70

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Fix type from number to integer #70

merged 1 commit into from
Mar 21, 2022

Conversation

isabelle-dr
Copy link
Contributor

@isabelle-dr isabelle-dr commented Mar 21, 2022 •
edited
Loading

Closes #68

This PR fixes the type from number to integer of the following fields:

  • vehicle_types.json
    • g_CO2_km
    • wheel_count
    • max_permittes_speed
    • rated_power
  • geofencing_zones.json
    • start (timestamp field)
    • end (timestamp field)
  • station_status.json
    • last_reported (timestamp field)
  • system_alerts.json
    • start (timestamp field)
    • end (timestamp field)

@isabelle-dr isabelle-dr requested a review from mplsmitch March 21, 2022 20:26
@isabelle-dr
Copy link
Contributor Author

@mplsmitch I started over, PR #69 contained all the changes that I made when updating to V2.3-RC2 for some reason.
I corrected the other fields that you flagged in this comment, please take another look :)

@isabelle-dr isabelle-dr merged commit 5e02044 into master Mar 21, 2022
@testower testower mentioned this pull request Apr 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mplsmitch mplsmitch mplsmitch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

number types that can be integer in v2.3-RC2
2 participants
@isabelle-dr @mplsmitch