Fix for #94 (private IP querying) #100
Conversation
Changes from DataDog/dd-sdk-ios#830 Also added 'GENERATE_INFOPLIST_FILE = YES;' to Tests target in order for tests to run. Signed-off-by: jean <[email protected]>
|
I’d recommend we put it behind some configuration flag since there are
legit cases where you’d want to use Kronos with a local ntpd
Just out of curiosity what domain are you querying when you get local area
IPs?
…On Mon, Aug 22, 2022 at 6:48 AM Jean Sarda ***@***.***> wrote:
@jeannustre <https://github.com/jeannustre> requested your review on: #100
<#100> Fix for #94
<#94> (private IP
querying) as a code owner.
—
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYVMMHQWWC7BNULDWF2XDV2OAMPANCNFSM57HYA7AQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
I'm getting the system prompt asking for local network access with the default configuration, using |
|
If I understand correctly, you are saying your DNS resolves time.apple.com
to a local area IP? What’s your network setup? What DNS are you using?
Would be nice if we can debug a bit more your use case.
…On Tue, Aug 23, 2022 at 12:55 AM Jean Sarda ***@***.***> wrote:
I'm getting the system prompt asking for local network access with the
default configuration, using Clock.sync() with no parameters, so that
would be time.apple.com only.
—
Reply to this email directly, view it on GitHub
<#100 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABYVMPE4NQSCLSN4PD6V6DV2R7YTANCNFSM57HYA7AQ>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
|
My use case is the same as issue #94 : in an iOS app, using just I have had it happen some time ago on my device but did not take note of my network configuration, sorry. I have been receiving user reports about it but did not reproduce it myself since. Reading up more on DataDog's repo, I see that their fix I made a PR with is not working entirely on their end, sadly. But they have investigated the matter a lot more than I, maybe the issue there will be interesting to you. |
|
Hey folks! We're seeing similar reports from our users. What came to my mind is that time.apple.com might be resolved to something weird (cached?) for certain networks or mobile data providers. Anyways, we'll run a fork including this fix + using a different NTP host. I can update here if this reduces the occurrences of hitting the local network prompt. Cheers! |
|
Hi @zettlunic, did this seem to help ? We are also considering using another NTP host (pool.ntp.org) to see if the issue still occurs. |
|
It's still totally possible to get to this situation if the NTP server for some reason resolves to a private ip range. Like a local gateway serving as a dnsd can do that. Some wifi networks do that for redirecting to a landing, etc. |
@jeannustre unfortunately it did not. Even resolving pool.ntp.org lead to the prompt. See https://developer.apple.com/forums/thread/709691 for more details, I've also filed a feedback report (FB12047743) which hasn't been responded to. |
|
As I mentioned before. I can definitely see how this happens. This is how it can happen:
I guess a way this could be solved is to have a |
Changes from DataDog/dd-sdk-ios#830
Also added 'GENERATE_INFOPLIST_FILE = YES;' to Tests target in order for tests to run.