Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some memory leaks #46

Merged
merged 2 commits into from
Feb 2, 2022
Merged

Fix some memory leaks #46

merged 2 commits into from
Feb 2, 2022

Conversation

prj-
Copy link
Contributor

@prj- prj- commented Feb 2, 2022

No description provided.

@prj-
Copy link
Contributor Author

prj- commented Feb 2, 2022

Both commits are independent @lcirrottola, in case that's not clear from looking at the diff.

@lcirrottola
Copy link
Contributor

Thanks @prj- !

  • Ok for 2efae93.
  • I see the problem in bce0018 is that the function could return after having allocated intvalues, but before deallocating it.

@lcirrottola lcirrottola merged commit a57de46 into MmgTools:develop Feb 2, 2022
@prj- prj- deleted the jolivet/fix-leaks branch February 3, 2022 06:10
@prj-
Copy link
Contributor Author

prj- commented Feb 3, 2022

Thanks Luca. We still have a good amount of memory errors in Mmg that are being triggered by ParMmg. I'll try to clear things up and post an issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@prj- @lcirrottola