Added handle types for 2d/3d translation

[Daniel4144]

implemented #707

added HandleType.Translation2D and HandleType.Translation3D

sample:
https://github.com/Daniel4144/MixedRealityToolkit-Unity/tree/handles-sample
scene handles-sample.unity in project MRTKDevTemplate

[MaxPalmer-UH]

I took a look at the example scene and interactions and have added this video as context.

Unity_lUxR2tyGBh.mp4

[Daniel4144]

Side note to the video: Grabbing one of the three planar elements enables movement along two dimensions, which I think is not shown in the video.
The colliders for the other handles are quite big in that example so it might be difficult to grab the planes (I have only tested it with the far interactor)

[MaxPalmer-UH]

Side note to the video: Grabbing one of the three planar elements enables movement along two dimensions, which I think is not shown in the video. The colliders for the other handles are quite big in that example so it might be difficult to grab the planes (I have only tested it with the far interactor)

Thanks for that clarification.

[keveleigh]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Daniel4144]

Any update, will this be merged?

[ms-RistoRK]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[ms-RistoRK]

Thank you for your contribution, this change looks great. We are trying to keep the codebase as clean as possible so we encourage contributors to avoid leaving commented code out of main branch. Could you please remove the commented code?

[ms-RistoRK]

Thank you for your contribution, this change looks great. We are trying to keep the codebase as clean as possible so we encourage contributors to avoid leaving commented code out of main branch. Could you please remove the commented code?

[Daniel4144]

The same commented code is in all other if-branches, so I decided to keep it in the two branches I added. I think removing the comments only here would cause more headache, in case that code is still relevant in the future.
In fact, the new branches are just copies of the existing branch for HandleType.Translation where only the first line of the branch changed, which is arguably not the ideal solution. Alternatively, I could merge the three branches for the translation types and add another if-statement inside to calculate the correct translation vector.
Let me know what you think about it.

[ms-RistoRK]

I understand your point of view, I too leave commented sections in my personal branches. However, since this is an open-source project I think it is best to leave the code as clean as possible because not everyone in the community may have the same context as the author. @MixedRealityToolkit/mixedrealitytoolkit-unity-maintainers What are your thoughts on this?

[ms-RistoRK]

Thank you for your contribution, this change looks great. We are trying to keep the codebase as clean as possible so we encourage contributors to avoid leaving commented code out of main branch. Could you please remove the commented code?

[Daniel4144]

Just noticed that there were some bigger changes in the involved script in the meantime, that make it impossible to merge, so I guess this PR is obsolete...
Although these other changes seem to make it possible to add new, arbitrary translation types (even without touching the existing code), adding several different translation handles to the same boundscontrol as seen in the video above is not possible.