Fixed scan with skip #2357
Merged
Fixed scan with skip #2357
+7
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous test didn't catch the fact that the accumulator had been broke, it's value became the special value `SKIP`.
Dropped unnecessary ternary as suggested by @isiahmeadows Co-Authored-By: gamb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes an issue with scan that arose from #2207. The reducer no longer accepted SKIP value as a way of limiting child updates, instead the accumulator value became "SKIP".
For more context see my original change: #1957. The test I added wasn't sufficient to catch breaking change, that is also fixed in this PR! :)
Types of changes
Checklist:
docs/change-log.md