Bundled version mismatched with source

[starsolaris]

Bundled version of mithril.js from next branch has some code mismatch with source:
https://github.com/MithrilJS/mithril.js/blob/next/mithril.js
line 1143:
key !== "href" && key2 !== "list" && key2 !== "form" && key2 !== "width" && key2 !== "height"// && key2 !== "type"
in method
function hasPropertyKey(vnode, key2, ns)

but should be key2 !== "href"

like in source render/render.js

[pygy]

Ooof... The bundler strikes again :-/

Great catch @starsolaris! Thanks for the report...

... though I wish this hadn't popped up, I haven't been in the bundlers for eons, and while it may be short, it is anything but simple...

[spacejack]

Is this the only issue blocking a V2 release?

Should we try using rollup instead of bundler?

[dead-claudia]

@spacejack I'd love to switch this to Rollup, but I'd rather not block v2 on this.

[spacejack]

@isiahmeadows I'm wondering what's the "least blocking" of options - fix bundler or switch to Rollup?

[dead-claudia]

Neither is really "breaking", just it needs fixed, and switching to Rollup would likely be a lot more time-consuming than just fixing the bundler.

[spacejack]

That's what I meant, which would take more effort. Are there difficulties in using Rollup beyond making a config? EDIT: Found this comment so I guess it is more involved than just "adding rollup".

[spacejack]

Changing hasPropertyKey in render.js to:

function hasPropertyKey(vnode, key, ns) {
	// Filter out namespaced keys
	return ns === undefined && (
		// If it's a custom element, just keep it.
		vnode.tag.indexOf("-") > -1 || vnode.attrs != null && vnode.attrs.is
		// If it's a normal element, let's try to avoid a few browser bugs.
		|| key !== "href" && key !== "list" && key !== "form" && key !== "width" && key !== "height"// && key !== "type"
		// Defer the property check until *after* we check everything.
	) && key in vnode.dom
}

Prevents it from triggering the bundler bug. I'm at a loss trying to figure out bundler's logic for name mangled replacement though.