Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State Machine Improvements #160

Merged
merged 12 commits into from
Jan 19, 2024

Conversation

Byrdman32
Copy link
Member

@Byrdman32 Byrdman32 commented Jan 19, 2024

Clayton:

  • Move the IPS object from the Camera interface to AutonomyThread interface to improve abstraction. FPS can now be retrieved for the state machine.
  • Enabled the AutonomyThread IPS limiter for the state machine's main thread.
  • Added a stop state machine method and added it to main to fix an occasional segfault on program exit.

Eli:

  • Fixed names of State Machine Enumerators to follow the proper Mars Rover Design Team naming scheme. Previously they were using the format of States::Idle but the proper format is States::eIdle.

@Byrdman32 Byrdman32 added enhancement Requests for new features or improvements to existing features. 2-Star Indicates a relatively easy task, requiring some basic skills or knowledge but still accessible. formatting Issues related to code formatting, style enforcement, or linting tasks. logging Tasks related to improving, fixing, or adding logging capabilities to the system. state-machine Issues related to the implementation, design, or modification of state machines in the system. labels Jan 19, 2024
@Byrdman32 Byrdman32 added this to the URC 2024 - Sprint 2b milestone Jan 19, 2024
@Byrdman32 Byrdman32 requested a review from a team as a code owner January 19, 2024 21:26
@Byrdman32 Byrdman32 self-assigned this Jan 19, 2024
@Byrdman32 Byrdman32 merged commit 9b63383 into development Jan 19, 2024
9 checks passed
@Byrdman32 Byrdman32 deleted the hotfix/state-machine-small-improvements branch January 19, 2024 21:37
MRDT-Software pushed a commit that referenced this pull request May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2-Star Indicates a relatively easy task, requiring some basic skills or knowledge but still accessible. enhancement Requests for new features or improvements to existing features. formatting Issues related to code formatting, style enforcement, or linting tasks. logging Tasks related to improving, fixing, or adding logging capabilities to the system. state-machine Issues related to the implementation, design, or modification of state machines in the system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants