Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Basic ArUco Vision Detection System #67 #140

Merged
merged 67 commits into from
Oct 20, 2023
Merged

Implement Basic ArUco Vision Detection System #67 #140

merged 67 commits into from
Oct 20, 2023

Conversation

ClayJay3
Copy link
Collaborator

  • Adds arucotag namespace for image preprocessing, detection, overlay, and pose estimation.
  • Adds tensorflowtag namespace for YOLOv8 detection of tag objects. (Only basic structure for now, will be implemented in Implement Advanced ArUco Vision Detection System #69)
  • Adds TagDetector class for mutithreaded, modular tag detection. Easily create new detectors for each camera with this class.
  • Adds appropriate handlers for creating tag detectors for cameras.

Closes #67

JSpencerPittman and others added 30 commits September 24, 2023 01:25
@JSpencerPittman
Aruco Vision Starter Code #67
113596f
@Byrdman32
Merge branch 'development' into topic/#67
8abd722
@Byrdman32
Move to ArUco Directory
a2d2923
@JSpencerPittman
Added camera pose estimation
dd94e6a
@JSpencerPittman
Meets style guide standards #67
acf7a11
@JSpencerPittman
Switched to .h from .hpp
5923d93
@JSpencerPittman
Bare bones ArucoThread
7ea122e
@JSpencerPittman
Implemented ArucoThread's basic structure #67
0332547
@JSpencerPittman
Removed ineffective pose estimation #67
473981d
@JSpencerPittman
Implemented scrappy ThreadContinousCode()
f2432d2
@JSpencerPittman
Fixed misspelling of aruco directory
e2e1d59
@JSpencerPittman
Implemented scrappy PooledLinearCode #67
109f916
@JSpencerPittman
Committed code and removed potential errors #67
36d9c4c
@Byrdman32
Merge branch 'development' into topic/#67
55408cb
@ClayJay3
Code feedback.
1af8e5c
@JSpencerPittman
Handled ArucoThread Fixme's
b85c432
@JSpencerPittman
Fixed general errors and addressed locking issues #67
ff34a8c
@JSpencerPittman
Converted ArucoDetector to a namespace 'aruco' #67
43ba47d
@JSpencerPittman
Created pose estimation from a point cloud
f33ad40
@JSpencerPittman
Created pose estimation for PNP #67
34d199d
@JSpencerPittman
Removed unecessary include #67
4dc98ce
@JSpencerPittman
Added pose estimation for the aruco thread and a mechanism for updati…
287d80b 
…ng detected tags #67
@JSpencerPittman
Cleaned up detected tag update mechanism #67
0fcf781
@ClayJay3
Merge remote-tracking branch 'origin/development' into topic/#67
311d0ee
@ClayJay3
Added required namespace changes.
1b92465
@ClayJay3
Restructured aruco vision.
e110922
@ClayJay3
Fixed class misname
fae65d5
@ClayJay3
Wrote TagDetectionHandler.
d1960fe
@JSpencerPittman
Fixed sort error and made compileable #67
75b4a59
@ClayJay3
Aruco vision is now testable.
a093aea
@ClayJay3 ClayJay3 added the 3-Star Indicates a moderate level of difficulty, requiring a good understanding of the topic or task. label Oct 19, 2023
@ClayJay3 ClayJay3 added this to the URC 2024 - Sprint 1 milestone Oct 19, 2023
@ClayJay3 ClayJay3 self-assigned this Oct 19, 2023
@ClayJay3 ClayJay3 requested a review from a team as a code owner October 19, 2023 04:02
Byrdman32
Byrdman32 requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@Byrdman32 Byrdman32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. A few minor things to change.

@ClayJay3 ClayJay3 requested a review from Byrdman32 October 20, 2023 03:01
@Byrdman32 Byrdman32 merged commit 7e98d37 into development Oct 20, 2023
@Byrdman32 Byrdman32 deleted the topic/#67 branch October 20, 2023 03:36
MRDT-Software pushed a commit that referenced this pull request May 14, 2024
@Byrdman32
Merge pull request #140 from MissouriMRDT/topic/#67
7db5f64 
 Implement Basic ArUco Vision Detection System #67
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Byrdman32 Byrdman32 Byrdman32 approved these changes

Assignees

@ClayJay3 ClayJay3

@ItzKiba ItzKiba

@JSpencerPittman JSpencerPittman

@Kai-Shafe Kai-Shafe

Labels
3-Star Indicates a moderate level of difficulty, requiring a good understanding of the topic or task.
Projects
None yet
Milestone
URC 2024 - Sprint 1
Development

Successfully merging this pull request may close these issues.

Implement Basic ArUco Vision Detection System
5 participants
@ClayJay3 @Byrdman32 @ItzKiba @JSpencerPittman @Kai-Shafe