Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly a fix to #210 #221

Merged
merged 6 commits into from
Feb 2, 2024
Merged

Possibly a fix to #210 #221

merged 6 commits into from
Feb 2, 2024

Conversation

TimeSignMaid
Copy link
Contributor

@TimeSignMaid TimeSignMaid commented Jan 28, 2024

Resolves #210.
https://docs.tmodloader.net/docs/stable/class_item.html , especially the "channel" attibute hints that my change might prevent unwanted behavior, since there seems to be no safe way to interrupt animations.
Rod of Discord, a few Whips, bows and Recall mirrors were tested with this, with no issues.

@Mirsario
Copy link
Owner

Mirsario commented Jan 29, 2024

The initial state of this allowed rolling at any point into any item use, which is unbalanced and nukes attack commitment. I've now reworked this in a balanced way with 3 rules:

  • Cannot halt a use into a roll if not at least ~20 ticks into the animation.
  • If an item has a reuseDelay - deny dodgerolls until the item goes into it.
  • If the item is a melee weapon - deny dodgerolls until the slash ends (Overhaul's melee weapons spend half of their use time in slashes)

Now for this to be playtested..

@Mirsario Mirsario merged commit 044fbcf into Mirsario:dev Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weapons don't let you dodgeroll due to their long, "animations"?
2 participants