Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIQ-33 #3

Merged
merged 1 commit into from
Jan 5, 2021
Merged

PIQ-33 #3

merged 1 commit into from
Jan 5, 2021

Conversation

MinjaMiladinovic
Copy link
Owner

No description provided.

@MinjaMiladinovic
Copy link
Owner Author

View detailed results in CodeScene

CodeScene PR Check
Recommended Review Level Inspect the code that degrades in code health.
Warnings Degrades in Code Health
  • EdXposed/xposed-bridge/src/main/java/de/robv/android/xposed/XposedBridge.java degrades from a Code Health of 8.06 -> 8.0
Code Health Delta Descriptions XposedBridge.java
  • Improvements:
    • Bumpy Road Ahead - no longer an issue
    • Complex Method - no longer an issue
  • Degradations:
    • Code Duplication (functions with similar structure: correctBatching,insertThenDeleteInBatchNoFlush,insertThenDeleteThenInsertInBatchFlush,insertThenDeleteWithSchemaThenInsertInBatchFlush and 5 more functions) - new issue

@MinjaMiladinovic MinjaMiladinovic merged commit bb5ed61 into master Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MinjaMiladinovic