Make Bukkit permission children be a map

[Proximyst]

Fixes #5

This makes the Bukkit permission children be a map instead of a list.

Code which says this is the case: https://hub.spigotmc.org/stash/projects/SPIGOT/repos/bukkit/browse/src/main/java/org/bukkit/plugin/PluginDescriptionFile.java#169-172

[stephan-gh]

That's not entirely correct, children can be also a list: https://github.com/Bukkit/Bukkit/blob/f210234e59275330f83b994e199c76f6abd41ee7/src/main/java/org/bukkit/plugin/PluginDescriptionFile.java#L727-L730, which I think covers the only useful case.

If you really want a map for some reason, then we should at least have an overload setter which accepts a list (for some sort of backwards compatibility).

[Proximyst]

While Groovy might be able to handle a setter such as setChildren(List<String>) just fine, Kotlin won't let you compile as it tries that on the map field. Do you have any ideas on how to do it in that case?

[stephan-gh]

Uh yeah. I forgot how/if that is possible in Kotlin... 🤔
(Haven't used Kotlin for months...)

[Proximyst]

I suppose making it something à la this would work?

children = listOf("perm.node") // Old API delegates to the under:
childrenMap = mapOf("perm.node" to true)

[stephan-gh]

@Proximyst Hm, yes. I suppose that would be the best solution. Thanks.

You would make children a @Transient @JsonIgnore so it doesn't get serialized. Then you add childrenMap with @JsonProperty("children"). That should work.

[stephan-gh]

FYI, this comment doesn't seem to be correct:

Execution failed for task ':Bukkit:generateBukkitPluginDescription'.
> com.fasterxml.jackson.databind.JsonMappingException: Conflicting getter definitions for property "children": net.minecrell.pluginyml.bukkit.BukkitPluginDescription$Permission#getChildren() vs net.minecrell.pluginyml.bukkit.BukkitPluginDescription$Permission#getChildrenMap() (through reference chain: net.minecrell.pluginyml.bukkit.BukkitPluginDescription["permissions"])

@JsonIgnore is needed on the getter to make it work.