Fixed diagnostic data loss and added devices list,

[ocrease]

Made the following changes to diagnostics:

• devices_data and engineers were previously dicts keyed by zone name. But mulitple devices can belong to the same zone. Converted both of these to lists so we can get all the data
• Instead of redacting the serial numbers completely, use a unique redacted string for each individual serial number. (Serial Numbers are important for the unique id generation, so knowing if devices share the same serial number is important)
• Added list of zones, list of devices (which I think are devices that are not stats or timers) and list of devices per zone (again I think only devices which are not stats or timers)
• Added raw_live_data. The neohubapi has logic that removes devices if they don't have a device id (repeaters?). Would be nice to see that they exist in the data returned by the hub and then we can decide if/how they can be supported

@MindrustUK if you can easily try this before the merge it would be good. In particular the new devices and device_list entries are empty on my setup, so handling them involved guesswork.

[MindrustUK]

Pulled this locally, attached is the logs. Let me know how this goes.

config_entry-heatmiserneo-01JBBYB1WMEZYMXKHBGFAQQA72.zip

[ocrease]

Hi @MindrustUK looks like my changes worked as I expected, but I got the impression you had more devices? I don't see the imaginary swimming pool for example? I see the following devices reported, is this what you would expect?

DEVICE_ID	Device Type	Model	ZONE_NAME
1	12	NeoStat V2	Bathroom
2	1	NeoStat V1	Heating
3	11	NeoStat HC	NeoStatHC
4	12	NeoStat V2	Kitchen
5	6	Neo Plug	Den
6	5	Contact Sensor	Spare Room
7	1	NeoStat V1	TestTimer
8	14	Air Sensor	Server Room
9	7	NeoAir	TestNeoAir1

Are the Air Sensor and Contact Sensor standalone devices or are they linked to one of the other devices? I was also expecting two devices for the NeoAir, it looks like I only see the thermostat part. Do you have the timer part disabled?

[MindrustUK]

That's the correct number of devices, I've not got many "production" devices; the Heating, Kitchen and Bathroom are the only "Real" thermostats in use.
The rest of the devices are part of my test suite.
I must've renamed the more exotic rooms to mundane descriptions, so nothing is missing.
The sensors aren't linked to anything, i.e. they are stand alone.

The NeoAir V1 is in mode 1. I suspect what you were expecting to see is the device operating in mode 3 (This is guess work on my part as I haven't tested the stat in this mode). I'll spawn a ticket for NeoAir support and let's further that point on there. I'm keen that we limit some of the scope before we end up balling all the work into a single ticket.

[ocrease]

@MindrustUK In that case I think you can merge this ticket (diagnostics)