allow bool arguments without a sink variable

MikkelSchubert · Jul 28, 2024 · 9fd6d5d · 9fd6d5d
1 parent 078a5b6
commit 9fd6d5d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/src/argparse.cpp b/src/argparse.cpp
@@ -696,10 +696,8 @@ sink::preprocess(std::string value) const
 
 bool_sink::bool_sink(bool* ptr)
   : sink(0)
-  , m_sink(ptr)
+  , m_sink(ptr ? ptr : &m_fallback_sink)
 {
-  AR_REQUIRE(ptr);
-
   *m_sink = false;
 }
 

diff --git a/src/argparse.hpp b/src/argparse.hpp
@@ -362,6 +362,8 @@ class bool_sink : public sink
 
 private:
   bool* m_sink;
+  //! Sink variable used if no sink was supplied
+  bool m_fallback_sink = false;
 };
 
 class uint_sink : public sink

diff --git a/tests/unit/argparse_test.cpp b/tests/unit/argparse_test.cpp
@@ -41,11 +41,6 @@ using Catch::Matchers::Contains;
 ///////////////////////////////////////////////////////////////////////////////
 // boolean sink
 
-TEST_CASE("bool sink is required", "[argparse::bool_sink]")
-{
-  REQUIRE_THROWS_AS(argparse::bool_sink(nullptr), assert_failed);
-}
-
 TEST_CASE("bool sink is initialized", "[argparse::bool_sink]")
 {
   bool value = true;