This repository has been archived by the owner on Jan 15, 2025. It is now read-only.
iframe.js: Update content in a more compatible way #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implementation was very error prone as it relied on the exact location of the existing content and updated content. If there was any difference, the update from the behavior didn't work correctly and produced an incorrect HTML hierarchy.
This will fix this so that the behavior is more compatible with how the content it is rendering is structured. I've also included basic support for Icinga DB Web, though this might be still subject to change. I hope to remember to notify you if this is the case. 🙄
The behavior should now work fine, as long as the following is the case:
.module-grafana iframe
.module-grafana
is a direct child of.content
(or.content > .host-detail
in case of Icinga DB Web).content
is a direct child of the content being rendered