fix addOne/subOne for SVInt #729
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: adream307 <[email protected]>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #729 +/- ##
=======================================
Coverage 91.49% 91.49%
=======================================
Files 188 188
Lines 43866 43868 +2
=======================================
+ Hits 40134 40136 +2
Misses 3732 3732
Continue to review full report in Codecov by Sentry.
|
|
Nice, thanks for finding this. |
jameshanlon
pushed a commit
to jameshanlon/slang
that referenced
this pull request
Mar 16, 2023
* master: fix addOne/subOne for SVInt (MikePopoloski#729) Fix off-by-one error in check for max object size Update CHANGELOG Make error about implicit named port connection type mismatches be convertible to a warning for VCS compat Fix gcc build Add a command line option to suppress warnings for files within a given path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix addOne/subOne for SVInt