Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --obfuscate-ids option to driver #660

Merged
merged 4 commits into from
Nov 20, 2022
Merged

Add --obfuscate-ids option to driver #660

merged 4 commits into from
Nov 20, 2022

Conversation

Sustrak
Copy link
Contributor

@Sustrak Sustrak commented Nov 19, 2022

With this option the preprocessed output will have all of its identifiers randomized.

It might come useful in order to share SV code without having to use a commercial encryption tool.

Sustrak and others added 2 commits November 19, 2022 16:52
With this option the preprocessed output will have all of its identifiers
randomized.
@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #660 (a3c9932) into master (4c7e8cf) will decrease coverage by 0.08%.
The diff coverage is 10.71%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #660      +/-   ##
==========================================
- Coverage   91.19%   91.11%   -0.09%     
==========================================
  Files         185      185              
  Lines       43020    43063      +43     
==========================================
+ Hits        39232    39235       +3     
- Misses       3788     3828      +40     
Impacted Files Coverage Δ
include/slang/driver/Driver.h 100.00% <ø> (ø)
source/driver/Driver.cpp 93.67% <10.71%> (-5.22%) ⬇️
source/ast/types/TypePrinter.cpp 67.52% <0.00%> (-1.23%) ⬇️
source/ast/ASTContext.cpp 95.07% <0.00%> (-0.80%) ⬇️
source/ast/types/Type.cpp 94.50% <0.00%> (-0.63%) ⬇️
include/slang/ast/ASTVisitor.h 78.03% <0.00%> (-0.31%) ⬇️
source/ast/types/AllTypes.cpp 91.59% <0.00%> (-0.17%) ⬇️
source/ast/expressions/AssignmentExpressions.cpp 90.45% <0.00%> (-0.04%) ⬇️
include/slang/ast/Symbol.h 100.00% <0.00%> (ø)
include/slang/ast/ASTContext.h 100.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7e8cf...a3c9932. Read the comment docs.

Copy link
Owner

@MikePopoloski MikePopoloski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for the PR. It looks like it fails to build under clang due to a missing header; can you please fix that?

Also as a general comment I would prefer if this were named "obfuscate" instead of "fuzz". The latter term is overloaded already.

Thanks again!

source/driver/Driver.cpp Show resolved Hide resolved
Sustrak and others added 2 commits November 20, 2022 13:38
The term fuzz is already used for another purpose.
Also removed unnecessary insertion check.
@Sustrak Sustrak changed the title Add --fuzz-ids option to driver Add --obfuscate-ids option to driver Nov 20, 2022
@MikePopoloski MikePopoloski merged commit 7fab7e8 into MikePopoloski:master Nov 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants